[libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog

Andrea Bolognani posted 5 patches 6 years, 7 months ago
[libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog
Posted by Andrea Bolognani 6 years, 7 months ago
Debian has removed sheepdog from the distribution, and at this
point Debian 9 is now the only supported release that still
includes it.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 6459fa0..b28fa03 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -874,7 +874,8 @@ mappings:
     default: sheepdog
     CentOS:
     FreeBSD:
-    DebianSid:
+    Debian:
+    Debian9: sheepdog
 
   showmount:
     deb: nfs-common
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog
Posted by Daniel P. Berrangé 6 years, 7 months ago
On Mon, Jul 08, 2019 at 06:05:36PM +0200, Andrea Bolognani wrote:
> Debian has removed sheepdog from the distribution, and at this
> point Debian 9 is now the only supported release that still
> includes it.

s/only supported release/only supported Debian release/

because Fedora still ships it

It does look kind of zombie upstream though. No commits since 1 in Jun
2018, and before that nothing until mid 2017. 


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog
Posted by Andrea Bolognani 6 years, 7 months ago
On Mon, 2019-07-08 at 17:14 +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 08, 2019 at 06:05:36PM +0200, Andrea Bolognani wrote:
> > Debian has removed sheepdog from the distribution, and at this
> > point Debian 9 is now the only supported release that still
> > includes it.
> 
> s/only supported release/only supported Debian release/

I thought the fact that I was exclusively talking about Debian made
that obvious, but sure, I can make it obvious-er :)

> because Fedora still ships it

And so does Ubuntu... So at this point it actually might make more
sense to express the mapping as

  sheepdog:
    default:
    Fedora: sheepdog
    Ubuntu: sheepdog
    Debian9: sheepdog

to highlight the fact that shipping it is the exception rather than
the rule; accordingly, it also ends up being shorter O:-)

> It does look kind of zombie upstream though. No commits since 1 in Jun
> 2018, and before that nothing until mid 2017.

That's probably at least part of the reason why people have stopped
shipping it...

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog
Posted by Daniel P. Berrangé 6 years, 7 months ago
On Tue, Jul 09, 2019 at 09:51:29AM +0200, Andrea Bolognani wrote:
> On Mon, 2019-07-08 at 17:14 +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 08, 2019 at 06:05:36PM +0200, Andrea Bolognani wrote:
> > > Debian has removed sheepdog from the distribution, and at this
> > > point Debian 9 is now the only supported release that still
> > > includes it.
> > 
> > s/only supported release/only supported Debian release/
> 
> I thought the fact that I was exclusively talking about Debian made
> that obvious, but sure, I can make it obvious-er :)

It can be read both ways :-)

> 
> > because Fedora still ships it
> 
> And so does Ubuntu... So at this point it actually might make more
> sense to express the mapping as
> 
>   sheepdog:
>     default:
>     Fedora: sheepdog
>     Ubuntu: sheepdog
>     Debian9: sheepdog
> 
> to highlight the fact that shipping it is the exception rather than
> the rule; accordingly, it also ends up being shorter O:-)
> 
> > It does look kind of zombie upstream though. No commits since 1 in Jun
> > 2018, and before that nothing until mid 2017.
> 
> That's probably at least part of the reason why people have stopped
> shipping it...

Anyway with a tweaked commit message

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list