[libvirt] [PATCH] m4: Fix check for yajl.pc

Andrea Bolognani posted 1 patch 5 years, 4 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190708075942.7337-1-abologna@redhat.com
m4/virt-yajl.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] m4: Fix check for yajl.pc
Posted by Andrea Bolognani 5 years, 4 months ago
Commit 44b8df4cb4b3 introduced a check for yajl.pc that is
extremely similar to the one we already had in place for
readline.pc - so similar, in fact, that it's still looking
for readline.pc instead of yajl.pc :)

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 m4/virt-yajl.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4
index 70cfb983e3..b602abd0a7 100644
--- a/m4/virt-yajl.m4
+++ b/m4/virt-yajl.m4
@@ -24,7 +24,7 @@ AC_DEFUN([LIBVIRT_ARG_YAJL],[
 AC_DEFUN([LIBVIRT_CHECK_YAJL],[
   dnl YAJL JSON library http://lloyd.github.com/yajl/
 
-  PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0])
+  PKG_CHECK_EXISTS([yajl], [use_pkgconfig=1], [use_pkgconfig=0])
 
   if test $use_pkgconfig = 1; then
     dnl 2.0.3 was the version where the pkg-config file was first added
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] m4: Fix check for yajl.pc
Posted by Daniel P. Berrangé 5 years, 4 months ago
On Mon, Jul 08, 2019 at 09:59:42AM +0200, Andrea Bolognani wrote:
> Commit 44b8df4cb4b3 introduced a check for yajl.pc that is
> extremely similar to the one we already had in place for
> readline.pc - so similar, in fact, that it's still looking
> for readline.pc instead of yajl.pc :)
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  m4/virt-yajl.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4
> index 70cfb983e3..b602abd0a7 100644
> --- a/m4/virt-yajl.m4
> +++ b/m4/virt-yajl.m4
> @@ -24,7 +24,7 @@ AC_DEFUN([LIBVIRT_ARG_YAJL],[
>  AC_DEFUN([LIBVIRT_CHECK_YAJL],[
>    dnl YAJL JSON library http://lloyd.github.com/yajl/
>  
> -  PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0])
> +  PKG_CHECK_EXISTS([yajl], [use_pkgconfig=1], [use_pkgconfig=0])
>  
>    if test $use_pkgconfig = 1; then
>      dnl 2.0.3 was the version where the pkg-config file was first added

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list