[libvirt] [PATCH 0/8] more snapshot improvements [incremental backup saga]

Eric Blake posted 8 patches 4 years, 9 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190706043735.26284-1-eblake@redhat.com
include/libvirt/libvirt-domain-snapshot.h     |  7 +++
src/conf/snapshot_conf.h                      |  1 +
src/conf/virdomainmomentobjlist.h             | 14 ++++-
src/conf/virdomainsnapshotobjlist.h           | 10 +++-
src/conf/snapshot_conf.c                      | 54 +++++++------------
src/conf/virdomainmomentobjlist.c             | 49 ++++++++++++++++-
src/conf/virdomainsnapshotobjlist.c           | 13 +++++
src/libvirt-domain-snapshot.c                 | 17 +++++-
src/libvirt-domain.c                          |  9 ++--
src/qemu/qemu_driver.c                        |  6 ++-
src/test/test_driver.c                        |  6 ++-
src/vbox/vbox_common.c                        | 11 ++--
src/vz/vz_driver.c                            |  5 +-
tests/Makefile.am                             | 14 ++---
.../description_only.xml                      |  0
.../disk-invalid.xml                          |  0
.../disk-network-seclabel-invalid.xml         |  0
.../disk-seclabel.xml                         |  0
.../disk_driver_name_null.xml                 |  0
.../disk_snapshot.xml                         |  0
.../empty.xml                                 |  0
.../external_vm.xml                           |  0
.../name_and_description.xml                  |  0
.../name_only.xml                             |  0
.../noparent.xml                              |  0
.../all_parameters.xml                        |  0
.../disk-seclabel.xml                         |  0
.../disk_driver_name_null.xml                 |  0
.../disk_snapshot.xml                         |  0
.../disk_snapshot_redefine.xml                |  0
.../empty.xml                                 |  0
.../external_vm.xml                           |  0
.../external_vm_redefine.xml                  |  0
.../full_domain.xml                           |  0
.../metadata.xml                              |  0
.../name_and_description.xml                  |  0
.../noparent.xml                              |  0
.../noparent_nodescription.xml                |  0
.../noparent_nodescription_noactive.xml       |  0
...test.c => qemudomainsnapshotxml2xmltest.c} | 15 +++---
tests/virschematest.c                         |  4 +-
tests/virsh-snapshot                          | 16 ++++--
tools/virsh-snapshot.c                        | 25 ++++++++-
tools/virsh.pod                               | 14 +++--
44 files changed, 213 insertions(+), 77 deletions(-)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/description_only.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-invalid.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-network-seclabel-invalid.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-seclabel.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk_driver_name_null.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk_snapshot.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/empty.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/external_vm.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/name_and_description.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/name_only.xml (100%)
rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/noparent.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/all_parameters.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk-seclabel.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_driver_name_null.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_snapshot.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_snapshot_redefine.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/empty.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/external_vm.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/external_vm_redefine.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/full_domain.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/metadata.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/name_and_description.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent_nodescription.xml (100%)
rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent_nodescription_noactive.xml (100%)
rename tests/{domainsnapshotxml2xmltest.c => qemudomainsnapshotxml2xmltest.c} (91%)
[libvirt] [PATCH 0/8] more snapshot improvements [incremental backup saga]
Posted by Eric Blake 4 years, 9 months ago
Various things that I've tweaked while working on addressing Peter's
comments about my v8.5 checkpoint series.  I'm less certain about
patches 7 and 8 (as having multiple ways to spell an operation, but
where one way fails with older servers, can be confusing), we may want
to drop those two and just take the first 6.

Eric Blake (8):
  snapshot: Rename qemu domain snapshot test files
  snapshot: Fix virDomainUndefineFlags docs regarding snapshots
  snapshot: Add internal option to validate XML against schema
  snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag
  snapshot: Factor out redefine cycle validation
  backup: Add support for filtering based on current moment
  snapshot: Add ListAll filters for current snapshot
  snapshot: Expose new filter flags in virsh

 include/libvirt/libvirt-domain-snapshot.h     |  7 +++
 src/conf/snapshot_conf.h                      |  1 +
 src/conf/virdomainmomentobjlist.h             | 14 ++++-
 src/conf/virdomainsnapshotobjlist.h           | 10 +++-
 src/conf/snapshot_conf.c                      | 54 +++++++------------
 src/conf/virdomainmomentobjlist.c             | 49 ++++++++++++++++-
 src/conf/virdomainsnapshotobjlist.c           | 13 +++++
 src/libvirt-domain-snapshot.c                 | 17 +++++-
 src/libvirt-domain.c                          |  9 ++--
 src/qemu/qemu_driver.c                        |  6 ++-
 src/test/test_driver.c                        |  6 ++-
 src/vbox/vbox_common.c                        | 11 ++--
 src/vz/vz_driver.c                            |  5 +-
 tests/Makefile.am                             | 14 ++---
 .../description_only.xml                      |  0
 .../disk-invalid.xml                          |  0
 .../disk-network-seclabel-invalid.xml         |  0
 .../disk-seclabel.xml                         |  0
 .../disk_driver_name_null.xml                 |  0
 .../disk_snapshot.xml                         |  0
 .../empty.xml                                 |  0
 .../external_vm.xml                           |  0
 .../name_and_description.xml                  |  0
 .../name_only.xml                             |  0
 .../noparent.xml                              |  0
 .../all_parameters.xml                        |  0
 .../disk-seclabel.xml                         |  0
 .../disk_driver_name_null.xml                 |  0
 .../disk_snapshot.xml                         |  0
 .../disk_snapshot_redefine.xml                |  0
 .../empty.xml                                 |  0
 .../external_vm.xml                           |  0
 .../external_vm_redefine.xml                  |  0
 .../full_domain.xml                           |  0
 .../metadata.xml                              |  0
 .../name_and_description.xml                  |  0
 .../noparent.xml                              |  0
 .../noparent_nodescription.xml                |  0
 .../noparent_nodescription_noactive.xml       |  0
 ...test.c => qemudomainsnapshotxml2xmltest.c} | 15 +++---
 tests/virschematest.c                         |  4 +-
 tests/virsh-snapshot                          | 16 ++++--
 tools/virsh-snapshot.c                        | 25 ++++++++-
 tools/virsh.pod                               | 14 +++--
 44 files changed, 213 insertions(+), 77 deletions(-)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/description_only.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-invalid.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-network-seclabel-invalid.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk-seclabel.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk_driver_name_null.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/disk_snapshot.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/empty.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/external_vm.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/name_and_description.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/name_only.xml (100%)
 rename tests/{domainsnapshotxml2xmlin => qemudomainsnapshotxml2xmlin}/noparent.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/all_parameters.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk-seclabel.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_driver_name_null.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_snapshot.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/disk_snapshot_redefine.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/empty.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/external_vm.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/external_vm_redefine.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/full_domain.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/metadata.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/name_and_description.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent_nodescription.xml (100%)
 rename tests/{domainsnapshotxml2xmlout => qemudomainsnapshotxml2xmlout}/noparent_nodescription_noactive.xml (100%)
 rename tests/{domainsnapshotxml2xmltest.c => qemudomainsnapshotxml2xmltest.c} (91%)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list