test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors

[libvirt] [PATCH] test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors

Ilias Stamatis posted 1 patch 4 years, 9 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190704130812.29866-1-stamatis.iliass@gmail.com

src/test/test_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors

Posted by Ilias Stamatis 4 years, 9 months ago

Right now nerrors can be used unitialized in the last for loop causing
a bug.

Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
---
 src/test/test_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ce4ff1a582..2371581f51 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3275,7 +3275,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom,
     virDomainObjPtr vm = NULL;
     int ret = -1;
     size_t i;
-    size_t nerrors;
+    size_t nerrors = 0;

     virCheckFlags(0, -1);

--
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors

Posted by Erik Skultety 4 years, 9 months ago

On Thu, Jul 04, 2019 at 03:08:12PM +0200, Ilias Stamatis wrote:
> Right now nerrors can be used unitialized in the last for loop causing
> a bug.
>
> Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
> ---
Dan already fixed it in the meantime.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list