A couple coverity patches

[libvirt] [PATCH 0/2] A couple coverity patches

John Ferlan posted 2 patches 4 years, 10 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190621194337.23158-1-jferlan@redhat.com

src/cpu/cpu_x86.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] A couple coverity patches

Posted by John Ferlan 4 years, 10 months ago

Coverity has been tripped up a few more times recently... 
The memory leak patch probably I what I noted from Jiri's recent
CPU series. The return value check is older. It wasn't clear
though if the intention of the module was to ignore errors
so I just chose to error out like other similar callers. If
there's a better way - then other patches can be posted.

John Ferlan (2):
  cpu_x86: Fix memory leak - virCPUx86GetHost
  cpu_x86: Handle error in x86DataToCPU when calling x86DataAdd

 src/cpu/cpu_x86.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] A couple coverity patches

Posted by Michal Prívozník 4 years, 10 months ago

On 6/21/19 9:43 PM, John Ferlan wrote:
> Coverity has been tripped up a few more times recently... 
> The memory leak patch probably I what I noted from Jiri's recent
> CPU series. The return value check is older. It wasn't clear
> though if the intention of the module was to ignore errors
> so I just chose to error out like other similar callers. If
> there's a better way - then other patches can be posted.
> 
> John Ferlan (2):
>   cpu_x86: Fix memory leak - virCPUx86GetHost
>   cpu_x86: Handle error in x86DataToCPU when calling x86DataAdd
> 
>  src/cpu/cpu_x86.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list