[libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries

Andrea Bolognani posted 5 patches 4 years, 10 months ago
Failed in applying to current master (apply log)
.gitignore                   |     1 +
docs/Makefile.am             |    37 +-
docs/index.html.in           |     6 +-
docs/js/jquery-3.1.1.min.js  |     4 -
docs/js/jquery-3.4.1.js      | 10598 +++++++++++++++++++++++++++++++++
docs/js/jquery.rss-3.3.0.js  |   333 ++
docs/js/jquery.rss.min.js    |    11 -
docs/js/moment-2.24.0.js     |  4602 ++++++++++++++
docs/js/moment.min.js        |     7 -
docs/page.xsl                |     2 +-
docs/site.xsl                |     1 +
docs/subsite.xsl             |     1 +
libvirt.spec.in              |     5 +
m4/virt-external-programs.m4 |     2 +
14 files changed, 15578 insertions(+), 32 deletions(-)
delete mode 100644 docs/js/jquery-3.1.1.min.js
create mode 100644 docs/js/jquery-3.4.1.js
create mode 100644 docs/js/jquery.rss-3.3.0.js
delete mode 100644 docs/js/jquery.rss.min.js
create mode 100644 docs/js/moment-2.24.0.js
delete mode 100644 docs/js/moment.min.js
[libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries
Posted by Andrea Bolognani 4 years, 10 months ago
We're carrying around embedded copies of a few JavaScript libraries
for use in our homepage, and we've been unforgivably bad at keeping
them up to date. Address that.

While doing so, replace the minified version of each library with
its non-minified counterpart so that libvirt.git and release archives
will include the actual source code for them, rather than what is
basically the JavaScript equivalent of binary blobs.

Note that I consider this to be merely a stop-gap measure until we
start generating the blog roll, the only part of the libvirt website
that uses these libraries, on the server side and finally drop them
entirely. I don't have cycles to dedicate to that effort at the
moment though, and this is better than leaving the situation
unchanged for who knows how much longer.

Since the diffs are kinda big and honestly just not very interesting,
I've snipped them liberally; the unabridged version of this series
can be fetched with

  $ git fetch https://github.com/andreabolognani/libvirt js


Changes from [v2]:

  * import non-minified libraries and minify them at build time.

Changes from [v1]:

  * drop libraries instead of updating them.


[v2] https://www.redhat.com/archives/libvir-list/2019-June/msg00611.html
[v1] https://www.redhat.com/archives/libvir-list/2019-June/msg00551.html

Andrea Bolognani (5):
  docs: Update jQuery
  docs: Update Moment.js
  docs: Update jquery.rss
  docs: Perform JavaScript minimization at build time
  spec: Require uglifyjs for RPM build

 .gitignore                   |     1 +
 docs/Makefile.am             |    37 +-
 docs/index.html.in           |     6 +-
 docs/js/jquery-3.1.1.min.js  |     4 -
 docs/js/jquery-3.4.1.js      | 10598 +++++++++++++++++++++++++++++++++
 docs/js/jquery.rss-3.3.0.js  |   333 ++
 docs/js/jquery.rss.min.js    |    11 -
 docs/js/moment-2.24.0.js     |  4602 ++++++++++++++
 docs/js/moment.min.js        |     7 -
 docs/page.xsl                |     2 +-
 docs/site.xsl                |     1 +
 docs/subsite.xsl             |     1 +
 libvirt.spec.in              |     5 +
 m4/virt-external-programs.m4 |     2 +
 14 files changed, 15578 insertions(+), 32 deletions(-)
 delete mode 100644 docs/js/jquery-3.1.1.min.js
 create mode 100644 docs/js/jquery-3.4.1.js
 create mode 100644 docs/js/jquery.rss-3.3.0.js
 delete mode 100644 docs/js/jquery.rss.min.js
 create mode 100644 docs/js/moment-2.24.0.js
 delete mode 100644 docs/js/moment.min.js

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries
Posted by Christophe de Dinechin 4 years, 10 months ago

> On 19 Jun 2019, at 14:41, Andrea Bolognani <abologna@redhat.com> wrote:
> 
> We're carrying around embedded copies of a few JavaScript libraries
> for use in our homepage, and we've been unforgivably bad at keeping
> them up to date. Address that.
> 
> While doing so, replace the minified version of each library with
> its non-minified counterpart so that libvirt.git and release archives
> will include the actual source code for them, rather than what is
> basically the JavaScript equivalent of binary blobs.
> 
> Note that I consider this to be merely a stop-gap measure until we
> start generating the blog roll, the only part of the libvirt website
> that uses these libraries, on the server side and finally drop them
> entirely. I don't have cycles to dedicate to that effort at the
> moment though, and this is better than leaving the situation
> unchanged for who knows how much longer.
> 
> Since the diffs are kinda big and honestly just not very interesting,
> I've snipped them liberally; the unabridged version of this series
> can be fetched with
> 
>  $ git fetch https://github.com/andreabolognani/libvirt js
> 
> 
> Changes from [v2]:
> 
>  * import non-minified libraries and minify them at build time.
> 
> Changes from [v1]:
> 
>  * drop libraries instead of updating them.
> 
> 
> [v2] https://www.redhat.com/archives/libvir-list/2019-June/msg00611.html
> [v1] https://www.redhat.com/archives/libvir-list/2019-June/msg00551.html
> 
> Andrea Bolognani (5):
>  docs: Update jQuery
>  docs: Update Moment.js
>  docs: Update jquery.rss
>  docs: Perform JavaScript minimization at build time
>  spec: Require uglifyjs for RPM build

In the spec file, why do you BuildRequire uglify-js only on Fedora?
Does that mean that if you build elsewhere, you may end up with a
build that minifies or not depending on whether uglifyjs is in path or not?

> 
> .gitignore                   |     1 +
> docs/Makefile.am             |    37 +-
> docs/index.html.in           |     6 +-
> docs/js/jquery-3.1.1.min.js  |     4 -
> docs/js/jquery-3.4.1.js      | 10598 +++++++++++++++++++++++++++++++++
> docs/js/jquery.rss-3.3.0.js  |   333 ++
> docs/js/jquery.rss.min.js    |    11 -
> docs/js/moment-2.24.0.js     |  4602 ++++++++++++++
> docs/js/moment.min.js        |     7 -
> docs/page.xsl                |     2 +-
> docs/site.xsl                |     1 +
> docs/subsite.xsl             |     1 +
> libvirt.spec.in              |     5 +
> m4/virt-external-programs.m4 |     2 +
> 14 files changed, 15578 insertions(+), 32 deletions(-)
> delete mode 100644 docs/js/jquery-3.1.1.min.js
> create mode 100644 docs/js/jquery-3.4.1.js
> create mode 100644 docs/js/jquery.rss-3.3.0.js
> delete mode 100644 docs/js/jquery.rss.min.js
> create mode 100644 docs/js/moment-2.24.0.js
> delete mode 100644 docs/js/moment.min.js
> 
> -- 
> 2.21.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries
Posted by Andrea Bolognani 4 years, 10 months ago
On Wed, 2019-06-19 at 17:00 +0200, Christophe de Dinechin wrote:
> > Andrea Bolognani (5):
> >  docs: Update jQuery
> >  docs: Update Moment.js
> >  docs: Update jquery.rss
> >  docs: Perform JavaScript minimization at build time
> >  spec: Require uglifyjs for RPM build
> 
> In the spec file, why do you BuildRequire uglify-js only on Fedora?

uglifyjs is not packaged for RHEL, which is the other platform our
spec file targets, so we can't really BuildRequire it there.

> Does that mean that if you build elsewhere, you may end up with a
> build that minifies or not depending on whether uglifyjs is in path or not?

Yeah. Luckily we're not going with these patches but with Martin's
approach instead, which neatly sidesteps this issue :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries
Posted by Christophe de Dinechin 4 years, 10 months ago

> On 20 Jun 2019, at 12:25, Andrea Bolognani <abologna@redhat.com> wrote:
> 
> On Wed, 2019-06-19 at 17:00 +0200, Christophe de Dinechin wrote:
>>> Andrea Bolognani (5):
>>> docs: Update jQuery
>>> docs: Update Moment.js
>>> docs: Update jquery.rss
>>> docs: Perform JavaScript minimization at build time
>>> spec: Require uglifyjs for RPM build
>> 
>> In the spec file, why do you BuildRequire uglify-js only on Fedora?
> 
> uglifyjs is not packaged for RHEL, which is the other platform our
> spec file targets, so we can't really BuildRequire it there.

I was afraid that was the reason ;-)

> 
>> Does that mean that if you build elsewhere, you may end up with a
>> build that minifies or not depending on whether uglifyjs is in path or not?
> 
> Yeah. Luckily we're not going with these patches but with Martin's
> approach instead, which neatly sidesteps this issue :)

OK.

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list