test_driver: improve testDomainInterfaceAddresses

[libvirt] [PATCH 0/3] test_driver: improve testDomainInterfaceAddresses

Ilias Stamatis posted 3 patches 4 years, 10 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190619111817.19562-1-stamatis.iliass@gmail.com

src/test/test_driver.c | 96 +++++++++++++++++++++++++++++++++++++-----
1 file changed, 86 insertions(+), 10 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] test_driver: improve testDomainInterfaceAddresses

Posted by Ilias Stamatis 4 years, 10 months ago

This patch series introduces the following improvements to the
testDomainInterfaceAddresses function:

- if a dhcp range is defined for the network, addresses are returned
  from there (instead of hard-coded addresses that were returned before)
- if the network is IPv6 even when a dhcp range is not defined IPv6
  addresses will be returned instead of IPv4
- the @source argument is validated
- only networks of type VIR_DOMAIN_NET_TYPE_NETWORK are considered

Ilias Stamatis (3):
  test_driver: validate @source in testDomainInterfaceAddresses
  test_driver: return addresses only for nets of type network
  test_driver: consider DHCP ranges in testDomainInterfaceAddresses

 src/test/test_driver.c | 96 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 86 insertions(+), 10 deletions(-)

--
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] test_driver: improve testDomainInterfaceAddresses

Posted by Ilias Stamatis 4 years, 10 months ago

On Wed, Jun 19, 2019 at 1:18 PM Ilias Stamatis
<stamatis.iliass@gmail.com> wrote:
>
> This patch series introduces the following improvements to the
> testDomainInterfaceAddresses function:
>
> - if a dhcp range is defined for the network, addresses are returned
>   from there (instead of hard-coded addresses that were returned before)
> - if the network is IPv6 even when a dhcp range is not defined IPv6
>   addresses will be returned instead of IPv4
> - the @source argument is validated
> - only networks of type VIR_DOMAIN_NET_TYPE_NETWORK are considered
>
> Ilias Stamatis (3):
>   test_driver: validate @source in testDomainInterfaceAddresses
>   test_driver: return addresses only for nets of type network
>   test_driver: consider DHCP ranges in testDomainInterfaceAddresses
>
>  src/test/test_driver.c | 96 +++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 86 insertions(+), 10 deletions(-)
>
> --
> 2.22.0
>

self-NACK since I forgot to run make syntax-check and some changes
need to be done

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list