[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf

Daniel P. Berrangé posted 1 patch 4 years, 10 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190619104238.18566-1-berrange@redhat.com
src/remote/libvirtd.conf | 5 -----
1 file changed, 5 deletions(-)
[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf
Posted by Daniel P. Berrangé 4 years, 10 months ago
The libvirtd.conf file has a comment pointing people to format.html
which has nothing todo with the configuration file format.

It also has a comment about tests/daemon-conf which no longer exists,
and even if it did exist such comment is not relevant to end users
when this file is installed in /etc/.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/remote/libvirtd.conf | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf
index ac07df6930..233c127156 100644
--- a/src/remote/libvirtd.conf
+++ b/src/remote/libvirtd.conf
@@ -1,10 +1,5 @@
 # Master libvirt daemon configuration file
 #
-# For further information consult https://libvirt.org/format.html
-#
-# NOTE: the tests/daemon-conf regression test script requires
-# that each "PARAMETER = VALUE" line in this file have the parameter
-# name just after a leading "#".
 
 #################################################################
 #
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf
Posted by Michal Privoznik 4 years, 10 months ago
On 6/19/19 12:42 PM, Daniel P. Berrangé wrote:
> The libvirtd.conf file has a comment pointing people to format.html
> which has nothing todo with the configuration file format.
> 
> It also has a comment about tests/daemon-conf which no longer exists,
> and even if it did exist such comment is not relevant to end users
> when this file is installed in /etc/.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   src/remote/libvirtd.conf | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf
> index ac07df6930..233c127156 100644
> --- a/src/remote/libvirtd.conf
> +++ b/src/remote/libvirtd.conf
> @@ -1,10 +1,5 @@
>   # Master libvirt daemon configuration file
>   #
> -# For further information consult https://libvirt.org/format.html
> -#
> -# NOTE: the tests/daemon-conf regression test script requires
> -# that each "PARAMETER = VALUE" line in this file have the parameter
> -# name just after a leading "#".
>   
>   #################################################################
>   #
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list