[v1] test_driver: implement virDomainGetMemoryParameters

[libvirt] [PATCH] test_driver: implement virDomainGetMemoryParameters

Posted by Ilias Stamatis 6 years, 7 months ago

Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
---
 src/test/test_driver.c | 46 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 8ef843b203..9e8236a5b6 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1474,6 +1474,7 @@ static int testConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED,
     return 32;
 }

+
 static char *
 testConnectBaselineCPU(virConnectPtr conn ATTRIBUTE_UNUSED,
                        const char **xmlCPUs,
@@ -2498,6 +2499,50 @@ testDomainGetMaxVcpus(virDomainPtr domain)
                                             VIR_DOMAIN_VCPU_MAXIMUM));
 }

+
+#define TEST_ASSIGN_MEM_PARAM(index, name, value) \
+    if (index < *nparams && \
+        virTypedParameterAssign(&params[index], name, VIR_TYPED_PARAM_ULLONG, \
+                                value) < 0) \
+        goto cleanup
+
+static int
+testDomainGetMemoryParameters(virDomainPtr dom,
+                              virTypedParameterPtr params,
+                              int *nparams,
+                              unsigned int flags)
+{
+    int ret = -1;
+    virDomainObjPtr vm = NULL;
+
+    virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
+                  VIR_DOMAIN_AFFECT_CONFIG |
+                  VIR_TYPED_PARAM_STRING_OKAY, -1);
+
+    if ((*nparams) == 0) {
+        *nparams = 3;
+        return 0;
+    }
+
+    if (!(vm = testDomObjFromDomain(dom)))
+        goto cleanup;
+
+    TEST_ASSIGN_MEM_PARAM(0, VIR_DOMAIN_MEMORY_HARD_LIMIT, vm->def->mem.hard_limit);
+    TEST_ASSIGN_MEM_PARAM(1, VIR_DOMAIN_MEMORY_SOFT_LIMIT, vm->def->mem.soft_limit);
+    TEST_ASSIGN_MEM_PARAM(2, VIR_DOMAIN_MEMORY_SWAP_HARD_LIMIT, vm->def->mem.swap_hard_limit);
+
+    if (*nparams > 3)
+        *nparams = 3;
+
+    ret = 0;
+
+ cleanup:
+    virDomainObjEndAPI(&vm);
+    return ret;
+}
+#undef TEST_ASSIGN_MEM_PARAM
+
+
 static int
 testDomainSetVcpusFlags(virDomainPtr domain, unsigned int nrCpus,
                         unsigned int flags)
@@ -7162,6 +7207,7 @@ static virHypervisorDriver testHypervisorDriver = {
     .domainGetVcpus = testDomainGetVcpus, /* 0.7.3 */
     .domainGetVcpuPinInfo = testDomainGetVcpuPinInfo, /* 1.2.18 */
     .domainGetMaxVcpus = testDomainGetMaxVcpus, /* 0.7.3 */
+    .domainGetMemoryParameters = testDomainGetMemoryParameters, /* 5.5.0 */
     .domainGetXMLDesc = testDomainGetXMLDesc, /* 0.1.4 */
     .connectListDefinedDomains = testConnectListDefinedDomains, /* 0.1.11 */
     .connectNumOfDefinedDomains = testConnectNumOfDefinedDomains, /* 0.1.11 */
--
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test_driver: implement virDomainGetMemoryParameters

Posted by Ján Tomko 6 years, 7 months ago

On Thu, Jun 13, 2019 at 04:06:59PM +0200, Ilias Stamatis wrote:
>Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
>---
> src/test/test_driver.c | 46 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
>diff --git a/src/test/test_driver.c b/src/test/test_driver.c
>index 8ef843b203..9e8236a5b6 100644
>--- a/src/test/test_driver.c
>+++ b/src/test/test_driver.c
>@@ -1474,6 +1474,7 @@ static int testConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED,
>     return 32;
> }
>
>+
> static char *
> testConnectBaselineCPU(virConnectPtr conn ATTRIBUTE_UNUSED,
>                        const char **xmlCPUs,

Unrelated whitespace change.
(but the rest looks OK to me)

Jano

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test_driver: implement virDomainGetMemoryParameters

Posted by Ilias Stamatis 6 years, 7 months ago

On Tue, Jun 18, 2019 at 5:19 PM Ján Tomko <jtomko@redhat.com> wrote:
>
> On Thu, Jun 13, 2019 at 04:06:59PM +0200, Ilias Stamatis wrote:
> >Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
> >---
> > src/test/test_driver.c | 46 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> >
> >diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> >index 8ef843b203..9e8236a5b6 100644
> >--- a/src/test/test_driver.c
> >+++ b/src/test/test_driver.c
> >@@ -1474,6 +1474,7 @@ static int testConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED,
> >     return 32;
> > }
> >
> >+
> > static char *
> > testConnectBaselineCPU(virConnectPtr conn ATTRIBUTE_UNUSED,
> >                        const char **xmlCPUs,
>
> Unrelated whitespace change.
> (but the rest looks OK to me)
>
> Jano
>

Accidentally added. It can be removed before merging if you're happy
with the rest of the patch.

Thanks,
Ilias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list