tests: Include LDADDS in qemu_LDADDS

[libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

Posted by Andrea Bolognani 4 years, 10 months ago

Finally got around to implement the suggestion I made in

  https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html

Andrea Bolognani (3):
  tests: Tweak cputest_LDADDS
  tests: Tweak vircapstest_LDADD
  tests: Include LDADDS in qemu_LDADDS

 tests/Makefile.am | 44 +++++++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 19 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

Posted by Jim Fehlig 4 years, 10 months ago

On 6/12/19 5:19 AM, Andrea Bolognani wrote:
> Finally got around to implement the suggestion I made in
> 
>    https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html
> 
> Andrea Bolognani (3):
>    tests: Tweak cputest_LDADDS
>    tests: Tweak vircapstest_LDADD
>    tests: Include LDADDS in qemu_LDADDS
> 
>   tests/Makefile.am | 44 +++++++++++++++++++++++++-------------------
>   1 file changed, 25 insertions(+), 19 deletions(-)
> 

In addition to reviewing these changes, I also tested them in my LTO build 
setup. Other than the commit message nit in patch 1, looks good!

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

Posted by Andrea Bolognani 4 years, 10 months ago

On Wed, 2019-06-12 at 10:53 -0600, Jim Fehlig wrote:
> On 6/12/19 5:19 AM, Andrea Bolognani wrote:
> > Finally got around to implement the suggestion I made in
> > 
> >    https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html
> > 
> > Andrea Bolognani (3):
> >    tests: Tweak cputest_LDADDS
> >    tests: Tweak vircapstest_LDADD
> >    tests: Include LDADDS in qemu_LDADDS
> > 
> >   tests/Makefile.am | 44 +++++++++++++++++++++++++-------------------
> >   1 file changed, 25 insertions(+), 19 deletions(-)
> 
> In addition to reviewing these changes, I also tested them in my LTO build 
> setup. Other than the commit message nit in patch 1, looks good!

Neat!

I've fixed the commit message and pushed the series. Thanks for
testing and reviewing :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list