[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Sergei Turchanov posted 1 patch 14 weeks ago
Failed in applying to current master (apply log)
libvirt-lxc-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Posted by Sergei Turchanov 14 weeks ago
This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1

fdlist[i] erroneously was replaced by fdlist[1] which caused
lxcOpenNamespace to return a list with identical elements.
---
 libvirt-lxc-override.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
index 60c2e48..d7af154 100644
--- a/libvirt-lxc-override.c
+++ b/libvirt-lxc-override.c
@@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED,
         goto error;
 
     for (i = 0; i < c_retval; i++)
-        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error);
+        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error);
 
  cleanup:
     VIR_FREE(fdlist);
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Posted by Sergei Turchanov 11 weeks ago
Hello!

Two weeks passed and still this fix not applied. Is no one interested 
fixing it?
Wrong mailing list? Anything?

Please, answer.

On 10.06.2019 13:45, Sergei Turchanov wrote:
> This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
>
> fdlist[i] erroneously was replaced by fdlist[1] which caused
> lxcOpenNamespace to return a list with identical elements.
> ---
>   libvirt-lxc-override.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
> index 60c2e48..d7af154 100644
> --- a/libvirt-lxc-override.c
> +++ b/libvirt-lxc-override.c
> @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED,
>           goto error;
>   
>       for (i = 0; i < c_retval; i++)
> -        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error);
> +        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error);
>   
>    cleanup:
>       VIR_FREE(fdlist);


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Posted by Ján Tomko 11 weeks ago
On Tue, Jun 25, 2019 at 10:29:52AM +1000, Sergei Turchanov wrote:
>Hello!

Hi!

>
>Two weeks passed and still this fix not applied.

Oops.

>Is no one interested 
>fixing it?
>Wrong mailing list? Anything?
>
>Please, answer.
>
>On 10.06.2019 13:45, Sergei Turchanov wrote:
>>This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
>>
>>fdlist[i] erroneously was replaced by fdlist[1] which caused
>>lxcOpenNamespace to return a list with identical elements.

Thanks for catching this!

However to be able to catch this, per our rules:
https://libvirt.org/governance.html#contributors
we need you to provide a sign-off to certify you complied with the
Developer Certificate of Origin:
https://developercertificate.org/

Jano

>>---
>>  libvirt-lxc-override.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
>>index 60c2e48..d7af154 100644
>>--- a/libvirt-lxc-override.c
>>+++ b/libvirt-lxc-override.c
>>@@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED,
>>          goto error;
>>      for (i = 0; i < c_retval; i++)
>>-        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error);
>>+        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error);
>>   cleanup:
>>      VIR_FREE(fdlist);
>
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Posted by Sergei Turchanov 11 weeks ago
Hello!

On 25.06.2019 18:41, Ján Tomko wrote:
>
> Thanks for catching this!
>
> However to be able to catch this, per our rules:
> https://libvirt.org/governance.html#contributors
> we need you to provide a sign-off to certify you complied with the
> Developer Certificate of Origin:
> https://developercertificate.org/
>
> Jano
>
Thank you for the explantation. Re-sent the patch with sign-off line.

With best regards,

Sergei.


>>> ---
>>>  libvirt-lxc-override.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
>>> index 60c2e48..d7af154 100644
>>> --- a/libvirt-lxc-override.c
>>> +++ b/libvirt-lxc-override.c
>>> @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject 
>>> *self ATTRIBUTE_UNUSED,
>>>          goto error;
>>>      for (i = 0; i < c_retval; i++)
>>> -        VIR_PY_LIST_APPEND_GOTO(py_retval, 
>>> libvirt_intWrap(fdlist[1]), error);
>>> +        VIR_PY_LIST_APPEND_GOTO(py_retval, 
>>> libvirt_intWrap(fdlist[i]), error);
>>>   cleanup:
>>>      VIR_FREE(fdlist);
>>
>>
>> -- 
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list