qemu: Introduce SMMUv3 IOMMU support

[libvirt] [PATCH 02/11] qemu: Drop 'ret' from qemuBuildIOMMUCommandLine()

Posted by Andrea Bolognani 6 years, 8 months ago

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/qemu/qemu_command.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fcc6caf42f..4a3aa26d7e 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6930,7 +6930,6 @@ qemuBuildIOMMUCommandLine(virCommandPtr cmd,
 {
     virBuffer opts = VIR_BUFFER_INITIALIZER;
     const virDomainIOMMUDef *iommu = def->iommu;
-    int ret = -1;
 
     if (!iommu)
         return 0;
@@ -6971,9 +6970,8 @@ qemuBuildIOMMUCommandLine(virCommandPtr cmd,
     virCommandAddArg(cmd, "-device");
     virCommandAddArgBuffer(cmd, &opts);
 
-    ret = 0;
     virBufferFreeAndReset(&opts);
-    return ret;
+    return 0;
 }
 
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/11] qemu: Drop 'ret' from qemuBuildIOMMUCommandLine()

Posted by Ján Tomko 6 years, 8 months ago

On Tue, May 28, 2019 at 05:28:55PM +0200, Andrea Bolognani wrote:
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/qemu/qemu_command.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list