[libvirt] [ocaml PATCH] build: build with CAML_NAME_SPACE

Pino Toscano posted 1 patch 4 years, 11 months ago
Failed in applying to current master (apply log)
libvirt/Makefile.in | 1 +
1 file changed, 1 insertion(+)
[libvirt] [ocaml PATCH] build: build with CAML_NAME_SPACE
Posted by Pino Toscano 4 years, 11 months ago
This way no non-namespaced OCaml C symbols are used, reducing the risk
of clashes with other code.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
---
 libvirt/Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libvirt/Makefile.in b/libvirt/Makefile.in
index 3a68aed..77462c7 100644
--- a/libvirt/Makefile.in
+++ b/libvirt/Makefile.in
@@ -19,6 +19,7 @@ WIN32		= @WIN32@
 
 CFLAGS		= @CFLAGS@ \
 		   @LIBVIRT_CFLAGS@ \
+		   -DCAML_NAME_SPACE \
 		   -I.. \
 		   -I"$(shell ocamlc -where)" \
 		   @DEBUG@ @WARNINGS@ @CFLAGS_FPIC@
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [ocaml PATCH] build: build with CAML_NAME_SPACE
Posted by Richard W.M. Jones 4 years, 11 months ago
On Tue, May 28, 2019 at 10:29:43AM +0200, Pino Toscano wrote:
> This way no non-namespaced OCaml C symbols are used, reducing the risk
> of clashes with other code.
> 
> Signed-off-by: Pino Toscano <ptoscano@redhat.com>
> ---
>  libvirt/Makefile.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libvirt/Makefile.in b/libvirt/Makefile.in
> index 3a68aed..77462c7 100644
> --- a/libvirt/Makefile.in
> +++ b/libvirt/Makefile.in
> @@ -19,6 +19,7 @@ WIN32		= @WIN32@
>  
>  CFLAGS		= @CFLAGS@ \
>  		   @LIBVIRT_CFLAGS@ \
> +		   -DCAML_NAME_SPACE \
>  		   -I.. \
>  		   -I"$(shell ocamlc -where)" \
>  		   @DEBUG@ @WARNINGS@ @CFLAGS_FPIC@

ACK.

We should probably add that in a few other places too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list