[libvirt] [glib PATCH 11/16] event-test: LibvirtGLib.init() takes (at maximum) 1 argment

Fabiano Fidêncio posted 16 patches 6 years, 8 months ago
[libvirt] [glib PATCH 11/16] event-test: LibvirtGLib.init() takes (at maximum) 1 argment
Posted by Fabiano Fidêncio 6 years, 8 months ago
As 2 argments have been passed, whenever we try to run event-test we'd
get:
```
Using uri:qemu:///system
Traceback (most recent call last):
  File "event-test.py", line 62, in <module>
    main()
  File "event-test.py", line 51, in main
    LibvirtGLib.init(0, "")
TypeError: LibvirtGLib.init() takes exactly 1 argument (2 given)
```

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 examples/event-test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/event-test.py b/examples/event-test.py
index 2b25e0a..1f7d97e 100644
--- a/examples/event-test.py
+++ b/examples/event-test.py
@@ -48,7 +48,7 @@ def main():
 
     print "Using uri:" + uri
 
-    LibvirtGLib.init(0, "")
+    LibvirtGLib.init()
     LibvirtGLib.event_register()
     vc = libvirt.open(uri)
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [glib PATCH 11/16] event-test: LibvirtGLib.init() takes (at maximum) 1 argment
Posted by Daniel P. Berrangé 6 years, 8 months ago
On Mon, May 20, 2019 at 10:31:57AM +0200, Fabiano Fidêncio wrote:
> As 2 argments have been passed, whenever we try to run event-test we'd
> get:
> ```
> Using uri:qemu:///system
> Traceback (most recent call last):
>   File "event-test.py", line 62, in <module>
>     main()
>   File "event-test.py", line 51, in main
>     LibvirtGLib.init(0, "")
> TypeError: LibvirtGLib.init() takes exactly 1 argument (2 given)
> ```

A change from previous behaviour with pygobject.

> 
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
>  examples/event-test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> diff --git a/examples/event-test.py b/examples/event-test.py
> index 2b25e0a..1f7d97e 100644
> --- a/examples/event-test.py
> +++ b/examples/event-test.py
> @@ -48,7 +48,7 @@ def main():
>  
>      print "Using uri:" + uri
>  
> -    LibvirtGLib.init(0, "")
> +    LibvirtGLib.init()
>      LibvirtGLib.event_register()
>      vc = libvirt.open(uri)
>  
> -- 
> 2.21.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list