On 5/10/19 9:12 PM, Fabiano Fidêncio wrote:
> This series consists in two different things that, together, are needed
> to set <os firmware="efi|bios"/> as part of libvirt domain's XML.
>
> The first patch simply changes the XML adding the bit mentioned above.
> All the other patches, on the other hand, add enough (and nothing more
> than that) infra for consumers to check which are the supported
> firmwares (the ones listed by virConnectGetDomainCapabilities()).
>
> Fabiano Fidêncio (8):
> gconfig: Add _domain_os_set_firmware()
> gobject: Use the proper return type in
> _connection_get_capabilities_finish()
> gconfig: Add GVirConfigDomainCapabilities
> gconfig: Add GVirConfigDomainCapabilitiesOs
> gconfig: Add _domain_capabilities_get_os()
> gconfig: Add _domain_capabilities_os_get_firmwares()
> tests: Add basic test for domain capabilities
> gobject: Wrap virConnectGetDomainCapabilities()
>
> libvirt-gconfig/Makefile.am | 4 +
> .../libvirt-gconfig-domain-capabilities-os.c | 115 ++++++++++++
> .../libvirt-gconfig-domain-capabilities-os.h | 66 +++++++
> .../libvirt-gconfig-domain-capabilities.c | 94 ++++++++++
> .../libvirt-gconfig-domain-capabilities.h | 68 +++++++
> libvirt-gconfig/libvirt-gconfig-domain-os.c | 17 ++
> libvirt-gconfig/libvirt-gconfig-domain-os.h | 7 +
> libvirt-gconfig/libvirt-gconfig.h | 2 +
> libvirt-gconfig/libvirt-gconfig.sym | 8 +
> libvirt-gobject/libvirt-gobject-connection.c | 170 +++++++++++++++++-
> libvirt-gobject/libvirt-gobject-connection.h | 22 +++
> libvirt-gobject/libvirt-gobject.sym | 8 +
> tests/test-gconfig.c | 34 ++++
> tests/xml/gconfig-domain-capabilities-os.xml | 23 +++
> tests/xml/gconfig-domain-os.xml | 2 +-
> 15 files changed, 638 insertions(+), 2 deletions(-)
> create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.c
> create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.h
> create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-capabilities.c
> create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-capabilities.h
> create mode 100644 tests/xml/gconfig-domain-capabilities-os.xml
>
ACK, but see my comments before pushing, please.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list