Support gtk-vnc and make virt-viewer depend on it

Daniel P. Berrangé (6):
  mappings: add libgcrypt native & mingw packages
  mappings: add pulseaudio libs for native packages
  projects: add gtk-vnc project
  projects: make virt-viewer depend on gtk-vnc jobs
  mappings: remove gtk-vnc2 native and mingw packages
  jobs: allow test-suite.log to exist anywhere

 guests/host_vars/libvirt-centos-7/main.yml    |  1 +
 guests/host_vars/libvirt-debian-9/main.yml    |  1 +
 guests/host_vars/libvirt-debian-sid/main.yml  |  1 +
 guests/host_vars/libvirt-fedora-29/main.yml   |  1 +
 guests/host_vars/libvirt-fedora-30/main.yml   |  1 +
 .../host_vars/libvirt-fedora-rawhide/main.yml |  3 +++
 guests/host_vars/libvirt-freebsd-11/main.yml  |  1 +
 guests/host_vars/libvirt-freebsd-12/main.yml  |  1 +
 .../libvirt-freebsd-current/main.yml          |  1 +
 guests/host_vars/libvirt-ubuntu-18/main.yml   |  1 +
 .../build/jobs/autotools-check-job.yml        |  2 +-
 guests/playbooks/build/jobs/defaults.yml      |  3 +++
 .../build/projects/gtk-vnc+mingw32.yml        | 12 +++++++++
 .../build/projects/gtk-vnc+mingw64.yml        | 12 +++++++++
 guests/playbooks/build/projects/gtk-vnc.yml   | 12 +++++++++
 guests/vars/mappings.yml                      | 27 ++++++++++---------
 guests/vars/projects/gtk-vnc+mingw32.yml      |  6 +++++
 guests/vars/projects/gtk-vnc+mingw64.yml      |  6 +++++
 guests/vars/projects/gtk-vnc.yml              | 11 ++++++++
 guests/vars/projects/virt-viewer+mingw32.yml  |  1 -
 guests/vars/projects/virt-viewer+mingw64.yml  |  1 -
 guests/vars/projects/virt-viewer.yml          |  1 -
 jenkins/jobs/autotools.yaml                   |  2 +-
 jenkins/jobs/defaults.yaml                    |  3 +++
 jenkins/projects/gtk-vnc+mingw32.yaml         | 11 ++++++++
 jenkins/projects/gtk-vnc+mingw64.yaml         | 11 ++++++++
 jenkins/projects/gtk-vnc.yaml                 | 15 +++++++++++
 jenkins/projects/virt-viewer+mingw32.yaml     |  4 ++-
 jenkins/projects/virt-viewer+mingw64.yaml     |  4 ++-
 jenkins/projects/virt-viewer.yaml             |  4 ++-
 30 files changed, 140 insertions(+), 20 deletions(-)
 create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw32.yml
 create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw64.yml
 create mode 100644 guests/playbooks/build/projects/gtk-vnc.yml
 create mode 100644 guests/vars/projects/gtk-vnc+mingw32.yml
 create mode 100644 guests/vars/projects/gtk-vnc+mingw64.yml
 create mode 100644 guests/vars/projects/gtk-vnc.yml
 create mode 100644 jenkins/projects/gtk-vnc+mingw32.yaml
 create mode 100644 jenkins/projects/gtk-vnc+mingw64.yaml
 create mode 100644 jenkins/projects/gtk-vnc.yaml

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Support gtk-vnc and make virt-viewer depend on it

Something that I forgot to mention yesterday, is that even after
you install all required packages the build still fails on FreeBSD:

  $ mkdir build && cd build && ../autogen.sh
  ...
  checking sasl/sasl.h usability... no
  checking sasl/sasl.h presence... no
  checking for sasl/sasl.h... no
  configure: error: You must install the Cyrus SASL development package in order to compile GTK-VNC
  $

Interestingly, the FreeBSD port itself

  https://github.com/freebsd/freebsd-ports/blob/master/net/gtk-vnc/Makefile

doesn't seem to play any tricks that would help configure locate the
library - that is, of course, unless that 'bsd.port.mk' that gets
included at the end does something crazy like adjust include and
library paths so that /usr/local is searched as well. I haven't spent
time digging.

I see GTK-VNC is using old-school library detection and also seems to
support both SASL and SASL2. In libvirt we only support SASL2 and use
pkg-config for detection, and that works quite well on all platforms
we target... I wonder if they'd consider doing the same?

Either way, we have to address this before merging somehow if we want
virt-viewer builds to keep succeeding on CentOS CI.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list