[libvirt] [PATCH 0/2] Fix regression with network type handling

Daniel P. Berrangé posted 2 patches 4 years, 12 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190430123647.31155-1-berrange@redhat.com
src/conf/domain_conf.c                        | 33 +++----------------
src/libxl/libxl_conf.c                        | 21 ++++++++++--
src/lxc/lxc_driver.c                          | 15 +++------
src/network/bridge_driver.c                   | 11 +++++--
src/qemu/qemu_command.c                       |  8 ++---
src/qemu/qemu_driver.c                        |  2 +-
src/qemu/qemu_hotplug.c                       | 13 ++------
src/qemu/qemu_interface.c                     | 12 ++-----
src/qemu/qemu_process.c                       |  5 +--
.../disk-secinfo-upgrade-out.xml              |  2 +-
.../migration-in-params-in.xml                |  2 +-
.../migration-out-nbd-out.xml                 |  2 +-
.../migration-out-nbd-tls-out.xml             |  2 +-
.../migration-out-params-in.xml               |  2 +-
tests/qemustatusxml2xmldata/modern-in.xml     |  2 +-
15 files changed, 49 insertions(+), 83 deletions(-)
[libvirt] [PATCH 0/2] Fix regression with network type handling
Posted by Daniel P. Berrangé 4 years, 12 months ago
Problems pointed out at

  https://www.redhat.com/archives/libvir-list/2019-April/msg01412.html

It certainly isn't possible to fix these problems in time for release,
and probably never. So reverting is best, probably only, option.

Daniel P. Berrangé (2):
  Revert "virt drivers: don't handle type=network after resolving actual
    network type"
  Revert "network: use 'bridge' as actual type instead of 'network'"

 src/conf/domain_conf.c                        | 33 +++----------------
 src/libxl/libxl_conf.c                        | 21 ++++++++++--
 src/lxc/lxc_driver.c                          | 15 +++------
 src/network/bridge_driver.c                   | 11 +++++--
 src/qemu/qemu_command.c                       |  8 ++---
 src/qemu/qemu_driver.c                        |  2 +-
 src/qemu/qemu_hotplug.c                       | 13 ++------
 src/qemu/qemu_interface.c                     | 12 ++-----
 src/qemu/qemu_process.c                       |  5 +--
 .../disk-secinfo-upgrade-out.xml              |  2 +-
 .../migration-in-params-in.xml                |  2 +-
 .../migration-out-nbd-out.xml                 |  2 +-
 .../migration-out-nbd-tls-out.xml             |  2 +-
 .../migration-out-params-in.xml               |  2 +-
 tests/qemustatusxml2xmldata/modern-in.xml     |  2 +-
 15 files changed, 49 insertions(+), 83 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] Fix regression with network type handling
Posted by Michal Privoznik 4 years, 12 months ago
On 4/30/19 2:36 PM, Daniel P. Berrangé wrote:
> Problems pointed out at
> 
>    https://www.redhat.com/archives/libvir-list/2019-April/msg01412.html
> 
> It certainly isn't possible to fix these problems in time for release,
> and probably never. So reverting is best, probably only, option.
> 
> Daniel P. Berrangé (2):
>    Revert "virt drivers: don't handle type=network after resolving actual
>      network type"
>    Revert "network: use 'bridge' as actual type instead of 'network'"
> 
>   src/conf/domain_conf.c                        | 33 +++----------------
>   src/libxl/libxl_conf.c                        | 21 ++++++++++--
>   src/lxc/lxc_driver.c                          | 15 +++------
>   src/network/bridge_driver.c                   | 11 +++++--
>   src/qemu/qemu_command.c                       |  8 ++---
>   src/qemu/qemu_driver.c                        |  2 +-
>   src/qemu/qemu_hotplug.c                       | 13 ++------
>   src/qemu/qemu_interface.c                     | 12 ++-----
>   src/qemu/qemu_process.c                       |  5 +--
>   .../disk-secinfo-upgrade-out.xml              |  2 +-
>   .../migration-in-params-in.xml                |  2 +-
>   .../migration-out-nbd-out.xml                 |  2 +-
>   .../migration-out-nbd-tls-out.xml             |  2 +-
>   .../migration-out-params-in.xml               |  2 +-
>   tests/qemustatusxml2xmldata/modern-in.xml     |  2 +-
>   15 files changed, 49 insertions(+), 83 deletions(-)
> 

ACK and safe for freeze.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list