tests: Introduce and use TEST_QEMU_CAPS_PATH

[libvirt] [PATCH 0/4] tests: Introduce and use TEST_QEMU_CAPS_PATH

Andrea Bolognani posted 4 patches 5 years ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190416105600.1534-1-abologna@redhat.com

tests/domaincapstest.c       |  4 ++--
tests/qemuargv2xmltest.c     |  2 +-
tests/qemublocktest.c        |  3 +--
tests/qemucapabilitiestest.c |  4 ++--
tests/qemucaps2xmltest.c     |  4 ++--
tests/testutilsqemu.c        | 25 ++++++++++---------------
tests/testutilsqemu.h        |  8 ++++----
tests/testutilsqemuschema.c  |  3 +--
8 files changed, 23 insertions(+), 30 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] tests: Introduce and use TEST_QEMU_CAPS_PATH

Posted by Andrea Bolognani 5 years ago

Reduce repetition by replacing reutterances with reusable references.

Andrea Bolognani (4):
  tests: Make TEST_QEMU_CAPS_PATH public
  tests: Drop dirname argument from testQemuGetLatestCapsForArch()
  tests: Drop dirname argument from testQemuCapsIterate()
  tests: Use TEST_QEMU_CAPS_PATH wherever possible

 tests/domaincapstest.c       |  4 ++--
 tests/qemuargv2xmltest.c     |  2 +-
 tests/qemublocktest.c        |  3 +--
 tests/qemucapabilitiestest.c |  4 ++--
 tests/qemucaps2xmltest.c     |  4 ++--
 tests/testutilsqemu.c        | 25 ++++++++++---------------
 tests/testutilsqemu.h        |  8 ++++----
 tests/testutilsqemuschema.c  |  3 +--
 8 files changed, 23 insertions(+), 30 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] tests: Introduce and use TEST_QEMU_CAPS_PATH

Posted by Cole Robinson 5 years ago

On 4/16/19 6:55 AM, Andrea Bolognani wrote:
> Reduce repetition by replacing reutterances with reusable references.
> 
> Andrea Bolognani (4):
>   tests: Make TEST_QEMU_CAPS_PATH public
>   tests: Drop dirname argument from testQemuGetLatestCapsForArch()
>   tests: Drop dirname argument from testQemuCapsIterate()
>   tests: Use TEST_QEMU_CAPS_PATH wherever possible
> 
>  tests/domaincapstest.c       |  4 ++--
>  tests/qemuargv2xmltest.c     |  2 +-
>  tests/qemublocktest.c        |  3 +--
>  tests/qemucapabilitiestest.c |  4 ++--
>  tests/qemucaps2xmltest.c     |  4 ++--
>  tests/testutilsqemu.c        | 25 ++++++++++---------------
>  tests/testutilsqemu.h        |  8 ++++----
>  tests/testutilsqemuschema.c  |  3 +--
>  8 files changed, 23 insertions(+), 30 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso@redhat.com>

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list