[libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0

Daniel P. Berrangé posted 1 patch 5 years ago
Failed in applying to current master (apply log)
docs/news.xml | 10 ++++++++++
1 file changed, 10 insertions(+)
[libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
Posted by Daniel P. Berrangé 5 years ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/news.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 86c7734694..79b5658cc3 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -49,6 +49,16 @@
           release.
         </description>
       </change>
+      <change>
+        <summary>
+          Removed support for VirtualBox versions &lt; 5.0
+        </summary>
+        <description>
+          Support for managing VirtualBox releases prior to 5.0 has
+          been dropped. The upstream project has declared that these
+          versions are end of life several years ago.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
Posted by Peter Krempa 5 years ago
On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  docs/news.xml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 86c7734694..79b5658cc3 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -49,6 +49,16 @@
>            release.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          Removed support for VirtualBox versions &lt; 5.0
> +        </summary>
> +        <description>
> +          Support for managing VirtualBox releases prior to 5.0 has
> +          been dropped. The upstream project has declared that these
> +          versions are end of life several years ago.

In some previous versions we had <section title="Removed features">.

Selling this as 'Improvement' is probably not entirely correct from
users PoV.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
Posted by Daniel P. Berrangé 5 years ago
On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  docs/news.xml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/docs/news.xml b/docs/news.xml
> > index 86c7734694..79b5658cc3 100644
> > --- a/docs/news.xml
> > +++ b/docs/news.xml
> > @@ -49,6 +49,16 @@
> >            release.
> >          </description>
> >        </change>
> > +      <change>
> > +        <summary>
> > +          Removed support for VirtualBox versions &lt; 5.0
> > +        </summary>
> > +        <description>
> > +          Support for managing VirtualBox releases prior to 5.0 has
> > +          been dropped. The upstream project has declared that these
> > +          versions are end of life several years ago.
> 
> In some previous versions we had <section title="Removed features">.
> 
> Selling this as 'Improvement' is probably not entirely correct from
> users PoV.

Heh, ok. I thought forcing people off 5+ year old software was an
improvement :-P

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
Posted by Peter Krempa 5 years ago
On Tue, Apr 16, 2019 at 10:57:28 +0100, Daniel Berrange wrote:
> On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> > On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > ---
> > >  docs/news.xml | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/docs/news.xml b/docs/news.xml
> > > index 86c7734694..79b5658cc3 100644
> > > --- a/docs/news.xml
> > > +++ b/docs/news.xml
> > > @@ -49,6 +49,16 @@
> > >            release.
> > >          </description>
> > >        </change>
> > > +      <change>
> > > +        <summary>
> > > +          Removed support for VirtualBox versions &lt; 5.0
> > > +        </summary>
> > > +        <description>
> > > +          Support for managing VirtualBox releases prior to 5.0 has
> > > +          been dropped. The upstream project has declared that these
> > > +          versions are end of life several years ago.
> > 
> > In some previous versions we had <section title="Removed features">.
> > 
> > Selling this as 'Improvement' is probably not entirely correct from
> > users PoV.
> 
> Heh, ok. I thought forcing people off 5+ year old software was an
> improvement :-P

Generally that's true, butt when it breaks your setup you would not
consider that an improvement :).

ACK, but make sure that you run syntax-check prior to pushing. I'm not
sure whether the schema for <summary> allows &lt;.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
Posted by Daniel P. Berrangé 5 years ago
On Tue, Apr 16, 2019 at 12:02:30PM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 10:57:28 +0100, Daniel Berrange wrote:
> > On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> > > On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > > ---
> > > >  docs/news.xml | 10 ++++++++++
> > > >  1 file changed, 10 insertions(+)
> > > > 
> > > > diff --git a/docs/news.xml b/docs/news.xml
> > > > index 86c7734694..79b5658cc3 100644
> > > > --- a/docs/news.xml
> > > > +++ b/docs/news.xml
> > > > @@ -49,6 +49,16 @@
> > > >            release.
> > > >          </description>
> > > >        </change>
> > > > +      <change>
> > > > +        <summary>
> > > > +          Removed support for VirtualBox versions &lt; 5.0
> > > > +        </summary>
> > > > +        <description>
> > > > +          Support for managing VirtualBox releases prior to 5.0 has
> > > > +          been dropped. The upstream project has declared that these
> > > > +          versions are end of life several years ago.
> > > 
> > > In some previous versions we had <section title="Removed features">.
> > > 
> > > Selling this as 'Improvement' is probably not entirely correct from
> > > users PoV.
> > 
> > Heh, ok. I thought forcing people off 5+ year old software was an
> > improvement :-P
> 
> Generally that's true, butt when it breaks your setup you would not
> consider that an improvement :).
> 
> ACK, but make sure that you run syntax-check prior to pushing. I'm not
> sure whether the schema for <summary> allows &lt;.

I assume you meant "make check" - the docs.rng appears to allow any
character except \n, so we're safe here.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list