[v2] network: only reload firewall after firewalld is finished restarting

[libvirt] [PATCH v2 0/2] network: only reload firewall after firewalld is finished restarting

Laine Stump posted 2 patches 5 years ago

Diff against v1
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190412172658.3132-1-laine@laine.org

src/libvirt_private.syms    |  1 -
src/network/bridge_driver.c | 30 +++++++++++++++++----
src/util/virdbus.c          | 53 ++++++++++++-------------------------
src/util/virdbus.h          |  4 +--
src/util/virdbuspriv.h      |  4 ---
src/util/virfirewalld.c     |  8 +++---
src/util/virpolkit.c        | 12 ++++-----
src/util/virsystemd.c       |  6 ++---
tests/virpolkittest.c       | 24 ++++++++---------
9 files changed, 69 insertions(+), 73 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/2] network: only reload firewall after firewalld is finished restarting

Posted by Laine Stump 5 years ago

Explanation in Patch 2/2

Changes in v2:

* don't (erroneously) check the fields of the message if it's a
  "Reload" message; only do that if it's a NameOwnerChanged Message.

* merge virDBusMessageRead() and virDBusMessageDecode(), since they
  are now identical (new Patch 1/2)

Laine Stump (2):
  util: eliminate duplicate function virDBusMessageRead
  network: only reload firewall after firewalld is finished restarting

 src/libvirt_private.syms    |  1 -
 src/network/bridge_driver.c | 30 +++++++++++++++++----
 src/util/virdbus.c          | 53 ++++++++++++-------------------------
 src/util/virdbus.h          |  4 +--
 src/util/virdbuspriv.h      |  4 ---
 src/util/virfirewalld.c     |  8 +++---
 src/util/virpolkit.c        | 12 ++++-----
 src/util/virsystemd.c       |  6 ++---
 tests/virpolkittest.c       | 24 ++++++++---------
 9 files changed, 69 insertions(+), 73 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list