[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am

Andrea Bolognani posted 1 patch 1 week ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190412143902.19715-1-abologna@redhat.com
src/access/Makefile.inc.am      | 2 ++
src/admin/Makefile.inc.am       | 2 ++
src/bhyve/Makefile.inc.am       | 2 ++
src/conf/Makefile.inc.am        | 2 ++
src/cpu/Makefile.inc.am         | 2 ++
src/cpu_map/Makefile.inc.am     | 2 ++
src/esx/Makefile.inc.am         | 2 ++
src/hyperv/Makefile.inc.am      | 2 ++
src/interface/Makefile.inc.am   | 2 ++
src/libxl/Makefile.inc.am       | 2 ++
src/locking/Makefile.inc.am     | 2 ++
src/logging/Makefile.inc.am     | 2 ++
src/lxc/Makefile.inc.am         | 2 ++
src/network/Makefile.inc.am     | 2 ++
src/node_device/Makefile.inc.am | 2 ++
src/nwfilter/Makefile.inc.am    | 2 ++
src/openvz/Makefile.inc.am      | 2 ++
src/phyp/Makefile.inc.am        | 2 ++
src/qemu/Makefile.inc.am        | 2 ++
src/remote/Makefile.inc.am      | 2 ++
src/rpc/Makefile.inc.am         | 2 ++
src/secret/Makefile.inc.am      | 2 ++
src/security/Makefile.inc.am    | 2 ++
src/storage/Makefile.inc.am     | 2 ++
src/test/Makefile.inc.am        | 2 ++
src/util/Makefile.inc.am        | 2 ++
src/vbox/Makefile.inc.am        | 2 ++
src/vmware/Makefile.inc.am      | 2 ++
src/vmx/Makefile.inc.am         | 2 ++
src/vz/Makefile.inc.am          | 2 ++
src/xenapi/Makefile.inc.am      | 2 ++
src/xenconfig/Makefile.inc.am   | 2 ++
32 files changed, 64 insertions(+)

[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am

Posted by Andrea Bolognani 1 week ago
Vim has trouble figuring out the filetype automatically because
the name doesn't follow existing conventions; annotations like
the ones we already have in Makefile.ci help it out.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Changes from [v1]:

  * drop emacs annotation;
  * switch from filetype=make to filetype=automake.

[v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00867.html

 src/access/Makefile.inc.am      | 2 ++
 src/admin/Makefile.inc.am       | 2 ++
 src/bhyve/Makefile.inc.am       | 2 ++
 src/conf/Makefile.inc.am        | 2 ++
 src/cpu/Makefile.inc.am         | 2 ++
 src/cpu_map/Makefile.inc.am     | 2 ++
 src/esx/Makefile.inc.am         | 2 ++
 src/hyperv/Makefile.inc.am      | 2 ++
 src/interface/Makefile.inc.am   | 2 ++
 src/libxl/Makefile.inc.am       | 2 ++
 src/locking/Makefile.inc.am     | 2 ++
 src/logging/Makefile.inc.am     | 2 ++
 src/lxc/Makefile.inc.am         | 2 ++
 src/network/Makefile.inc.am     | 2 ++
 src/node_device/Makefile.inc.am | 2 ++
 src/nwfilter/Makefile.inc.am    | 2 ++
 src/openvz/Makefile.inc.am      | 2 ++
 src/phyp/Makefile.inc.am        | 2 ++
 src/qemu/Makefile.inc.am        | 2 ++
 src/remote/Makefile.inc.am      | 2 ++
 src/rpc/Makefile.inc.am         | 2 ++
 src/secret/Makefile.inc.am      | 2 ++
 src/security/Makefile.inc.am    | 2 ++
 src/storage/Makefile.inc.am     | 2 ++
 src/test/Makefile.inc.am        | 2 ++
 src/util/Makefile.inc.am        | 2 ++
 src/vbox/Makefile.inc.am        | 2 ++
 src/vmware/Makefile.inc.am      | 2 ++
 src/vmx/Makefile.inc.am         | 2 ++
 src/vz/Makefile.inc.am          | 2 ++
 src/xenapi/Makefile.inc.am      | 2 ++
 src/xenconfig/Makefile.inc.am   | 2 ++
 32 files changed, 64 insertions(+)

diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am
index 6d57ca1a1b..4dc742f4e5 100644
--- a/src/access/Makefile.inc.am
+++ b/src/access/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 ACCESS_DRIVER_GENERATED = \
 	access/viraccessapicheck.h \
 	access/viraccessapicheck.c \
diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index 19afb0e179..4cc588a47c 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x
 
 ADMIN_PROTOCOL_GENERATED = \
diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am
index fba1b9ef30..36af5d7504 100644
--- a/src/bhyve/Makefile.inc.am
+++ b/src/bhyve/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 BHYVE_DRIVER_SOURCES = \
 	bhyve/bhyve_capabilities.c \
 	bhyve/bhyve_capabilities.h \
diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am
index 6eb64db9de..3e9fdd1aea 100644
--- a/src/conf/Makefile.inc.am
+++ b/src/conf/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 NETDEV_CONF_SOURCES = \
 	conf/netdev_bandwidth_conf.h \
 	conf/netdev_bandwidth_conf.c \
diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am
index 5020d40583..0abeee87b6 100644
--- a/src/cpu/Makefile.inc.am
+++ b/src/cpu/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 CPU_SOURCES = \
 	cpu/cpu.h \
 	cpu/cpu.c \
diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am
index 9d7cef15c5..5634dd9348 100644
--- a/src/cpu_map/Makefile.inc.am
+++ b/src/cpu_map/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 cpumapdir = $(pkgdatadir)/cpu_map
 cpumap_DATA = \
 	cpu_map/index.xml \
diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am
index 152dd7b979..2d55c6573c 100644
--- a/src/esx/Makefile.inc.am
+++ b/src/esx/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 ESX_DRIVER_SOURCES = \
 	esx/esx_private.h \
 	esx/esx_driver.c \
diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am
index a768272b72..51be8bcacc 100644
--- a/src/hyperv/Makefile.inc.am
+++ b/src/hyperv/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 HYPERV_DRIVER_SOURCES = \
 	hyperv/hyperv_private.h \
 	hyperv/hyperv_driver.c \
diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am
index 08b35d040d..339a92786b 100644
--- a/src/interface/Makefile.inc.am
+++ b/src/interface/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 INTERFACE_DRIVER_SOURCES = \
 	interface/interface_driver.h \
 	interface/interface_driver.c \
diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am
index 59c136bf4e..7f60b449d8 100644
--- a/src/libxl/Makefile.inc.am
+++ b/src/libxl/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 LIBXL_DRIVER_SOURCES = \
 	libxl/libxl_conf.c \
 	libxl/libxl_conf.h \
diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am
index 5d5e923769..da26fab91f 100644
--- a/src/locking/Makefile.inc.am
+++ b/src/locking/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 DRIVER_SOURCES += \
 	locking/lock_manager.c \
 	locking/lock_manager.h \
diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am
index 3f4a87d91a..f5eba2a4f7 100644
--- a/src/logging/Makefile.inc.am
+++ b/src/logging/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 LOG_PROTOCOL_GENERATED = \
 	logging/log_protocol.h \
 	logging/log_protocol.c \
diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index 8dd2e9ea9e..f27827c1e9 100644
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 LXC_MONITOR_PROTOCOL_GENERATED = \
 	lxc/lxc_monitor_protocol.h \
 	lxc/lxc_monitor_protocol.c \
diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am
index cbaaa7ea68..3fed59c13b 100644
--- a/src/network/Makefile.inc.am
+++ b/src/network/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 NETWORK_DRIVER_SOURCES = \
 	network/bridge_driver.h \
 	network/bridge_driver.c \
diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am
index 0c3ad51273..3e04651e8c 100644
--- a/src/node_device/Makefile.inc.am
+++ b/src/node_device/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 NODE_DEVICE_DRIVER_SOURCES = \
 	node_device/node_device_driver.c \
 	node_device/node_device_driver.h \
diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am
index 27aa801095..810ca54bcc 100644
--- a/src/nwfilter/Makefile.inc.am
+++ b/src/nwfilter/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 NWFILTER_DRIVER_SOURCES = \
 	nwfilter/nwfilter_driver.h \
 	nwfilter/nwfilter_driver.c \
diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am
index baad737362..93bf3b9c96 100644
--- a/src/openvz/Makefile.inc.am
+++ b/src/openvz/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 OPENVZ_DRIVER_SOURCES = \
 	openvz/openvz_conf.c \
 	openvz/openvz_conf.h \
diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am
index 496ff25266..315f1c36ee 100644
--- a/src/phyp/Makefile.inc.am
+++ b/src/phyp/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 PHYP_DRIVER_SOURCES = \
 	phyp/phyp_driver.c \
 	phyp/phyp_driver.h \
diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
index 8d10e1085a..fd32a90d56 100644
--- a/src/qemu/Makefile.inc.am
+++ b/src/qemu/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 QEMU_DRIVER_SOURCES = \
 	qemu/qemu_agent.c \
 	qemu/qemu_agent.h \
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 13a1f9f8f2..06714249b4 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 REMOTE_DRIVER_GENERATED = \
 	remote/remote_protocol.c \
 	remote/remote_protocol.h \
diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am
index 722ef64db1..68a4945198 100644
--- a/src/rpc/Makefile.inc.am
+++ b/src/rpc/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 EXTRA_DIST += \
 	rpc/gendispatch.pl \
 	rpc/genprotocol.pl \
diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am
index 79c2b2d74a..7a1c8f8e1a 100644
--- a/src/secret/Makefile.inc.am
+++ b/src/secret/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 SECRET_DRIVER_SOURCES = \
 	secret/secret_driver.h \
 	secret/secret_driver.c \
diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am
index b24cdfd083..7fb6d8cc4f 100644
--- a/src/security/Makefile.inc.am
+++ b/src/security/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \
 	$(DATATYPES_SOURCES) \
 	security/virt-aa-helper.c \
diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am
index b4400b556f..ea4681f70e 100644
--- a/src/storage/Makefile.inc.am
+++ b/src/storage/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 STORAGE_DRIVER_BACKEND_SOURCES = \
 	storage/storage_backend.h \
 	storage/storage_backend.c \
diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am
index d52c281545..c20541a368 100644
--- a/src/test/Makefile.inc.am
+++ b/src/test/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 TEST_DRIVER_SOURCES = \
 	test/test_driver.c \
 	test/test_driver.h \
diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am
index 58874cca3c..f44d3b3b2a 100644
--- a/src/util/Makefile.inc.am
+++ b/src/util/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 # These files are not related to driver APIs. Simply generic
 # helper APIs for various purposes
 UTIL_SOURCES = \
diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am
index 8c76f84e82..15f7b78416 100644
--- a/src/vbox/Makefile.inc.am
+++ b/src/vbox/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 VBOX_DRIVER_SOURCES = \
 	vbox/vbox_glue.c \
 	vbox/vbox_glue.h \
diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am
index 0fbf866030..2c8c2d9884 100644
--- a/src/vmware/Makefile.inc.am
+++ b/src/vmware/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 VMWARE_DRIVER_SOURCES = \
 	vmware/vmware_driver.c \
 	vmware/vmware_driver.h \
diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am
index b9bf6ef690..429bdfe51e 100644
--- a/src/vmx/Makefile.inc.am
+++ b/src/vmx/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 VMX_SOURCES = \
 	vmx/vmx.c \
 	vmx/vmx.h \
diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am
index cacdb38795..a3a146c627 100644
--- a/src/vz/Makefile.inc.am
+++ b/src/vz/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 VZ_DRIVER_SOURCES = \
 	vz/vz_driver.h \
 	vz/vz_driver.c \
diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am
index 4640e9943f..b6e4ed0bdb 100644
--- a/src/xenapi/Makefile.inc.am
+++ b/src/xenapi/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 XENAPI_DRIVER_SOURCES = \
 	xenapi/xenapi_driver.c \
 	xenapi/xenapi_driver.h \
diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am
index a87d69990f..cd751029d2 100644
--- a/src/xenconfig/Makefile.inc.am
+++ b/src/xenconfig/Makefile.inc.am
@@ -1,3 +1,5 @@
+# vim: filetype=automake
+
 XENCONFIG_SOURCES = \
 	xenconfig/xenxs_private.h \
 	xenconfig/xen_common.c \
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am

Posted by Daniel P. Berrangé 1 week ago
On Fri, Apr 12, 2019 at 04:39:02PM +0200, Andrea Bolognani wrote:
> Vim has trouble figuring out the filetype automatically because
> the name doesn't follow existing conventions; annotations like
> the ones we already have in Makefile.ci help it out.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> Changes from [v1]:
> 
>   * drop emacs annotation;
>   * switch from filetype=make to filetype=automake.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list