[libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge

Andrea Bolognani posted 2 patches 6 years, 10 months ago
[libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge
Posted by Andrea Bolognani 6 years, 10 months ago
It's no longer needed as of libvirt commit dfe06e6202e4.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/update/tasks/kludges.yml | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml
index 708e7a4..3648514 100644
--- a/guests/playbooks/update/tasks/kludges.yml
+++ b/guests/playbooks/update/tasks/kludges.yml
@@ -1,18 +1,4 @@
 ---
-# libvirt can't detect these automatically at the moment, so a kludge
-# is required. Can be dropped it as soon as libvirt has been fixed
-- name: Create compatibility symlinks
-  file:
-    src: '/usr/local/{{ item }}'
-    dest: '/usr/{{ item }}'
-    state: link
-    force: yes
-  with_items:
-    - include/readline
-    - lib/libreadline.so
-  when:
-    - os_name == 'FreeBSD'
-
 # FreeBSD compiles bash without defining SSH_SOURCE_BASHRC, which means
 # it won't try to detect when it's spawned by ssh and source ~/.bashrc
 # when that's the case. Our workaround is setting $BASH_ENV globally
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge
Posted by Daniel P. Berrangé 6 years, 10 months ago
On Fri, Apr 12, 2019 at 04:31:36PM +0200, Andrea Bolognani wrote:
> It's no longer needed as of libvirt commit dfe06e6202e4.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/update/tasks/kludges.yml | 14 --------------
>  1 file changed, 14 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list