[v1] readline: Drop obsolete code, add pkg-config support

[libvirt] [PATCH 0/6] readline: Drop obsolete code, add pkg-config support

Andrea Bolognani posted 6 patches 5 years ago

Diff against v2
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190409131023.20275-1-abologna@redhat.com

There is a newer version of this series

m4/virt-readline.m4 | 68 ++++++++++++++++++++++-----------------------
tools/vsh.c         | 17 ------------
2 files changed, 33 insertions(+), 52 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/6] readline: Drop obsolete code, add pkg-config support

Posted by Andrea Bolognani 5 years ago

This series drops a bunch of compatibility code that's no longer
necessary to support our target platforms and introduces support
for getting readline's CFLAGS and LIBS via pkg-config, which in
turn makes it possible to automatically enable the feature on
FreeBSD.

There are a couple of caveats:

  * while most of the existing kludges are dropped, a new one had
    to be introduced :( The upsides are that the new kludge is small
    and straightforward, and that there's an expiration date on it
    already, since a patch making it unnecessary has already been
    provided for upstream readline;

  * autodetection on macOS still doesn't work because of a
    downstream packaging issue, but that's not any worse than the
    current situation anyway.

Andrea Bolognani (6):
  tools: vsh: Drop obsolete readline compatibility code
  m4: readline: Extract code setting -D_FUNCTION_DEF
  m4: readline: Stop looking for rl_completion_quote_character()
  m4: readline: Drop extra_LIBS machinery
  m4: readline: Use pkg-config
  m4: readline: Add gross kludge for include path

 m4/virt-readline.m4 | 68 ++++++++++++++++++++++-----------------------
 tools/vsh.c         | 17 ------------
 2 files changed, 33 insertions(+), 52 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] readline: Drop obsolete code, add pkg-config support

Posted by Andrea Bolognani 5 years ago

On Tue, 2019-04-09 at 15:10 +0200, Andrea Bolognani wrote:
[...]
>   * autodetection on macOS still doesn't work because of a
>     downstream packaging issue, but that's not any worse than the
>     current situation anyway.

Actually this breaks compilation on macOS, because now when the
pkg-config file is not present we'll pick up libedit from the base
system, which shadows readline, and fail because it doesn't provide
all the features we're expecting :(

I'll post a v2 that introduces no regressions in a bit.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list