fix minor bug in code example

[libvirt] [appdev-guide] [PATCH] fix minor bug in code example

Posted by Ilias Stamatis 5 years, 1 month ago

---
 en-US/Guest_Domains.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/en-US/Guest_Domains.xml b/en-US/Guest_Domains.xml
index c15bbb8..2a4ef7c 100644
--- a/en-US/Guest_Domains.xml
+++ b/en-US/Guest_Domains.xml
@@ -88,7 +88,7 @@ dom = virDomainLookupByID(conn, domainID);
     <example>
       <title>Fetching a domain object from an name</title>
       <programlisting>
-int domainName = "someguest";
+char *domainName = "someguest";
 virDomainPtr dom;

 dom = virDomainLookupByName(conn, domainName);
--
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

Posted by Ján Tomko 5 years, 1 month ago

The commit summary could be more specific, for example:
  Guest Domains: fix code example

but more importantly, it is missing a Sign-off.
See point 6 at https://libvirt.org/hacking.html#patches
    Contributors to libvirt projects must assert that they are in compliance
    with the Developer Certificate of Origin 1.1. This is achieved by adding
    a "Signed-off-by" line containing the contributor's name and e-mail to
    every commit message. The presence of this line attests that the contributor
    has read the above lined DCO and agrees with its statements.

(You can just provide the sign-off in an on-list reply to this e-mail
 and I will add it to the commit message before pushing)

Jano

On Fri, Apr 05, 2019 at 05:58:43PM +0200, Ilias Stamatis wrote:
>---
> en-US/Guest_Domains.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/en-US/Guest_Domains.xml b/en-US/Guest_Domains.xml
>index c15bbb8..2a4ef7c 100644
>--- a/en-US/Guest_Domains.xml
>+++ b/en-US/Guest_Domains.xml
>@@ -88,7 +88,7 @@ dom = virDomainLookupByID(conn, domainID);
>     <example>
>       <title>Fetching a domain object from an name</title>
>       <programlisting>
>-int domainName = "someguest";
>+char *domainName = "someguest";
> virDomainPtr dom;
>
> dom = virDomainLookupByName(conn, domainName);
>--
>2.21.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

Posted by Ilias Stamatis 5 years, 1 month ago

Στις Σάβ, 6 Απρ 2019 στις 10:10 π.μ., ο/η Ján Tomko <jtomko@redhat.com>
έγραψε:

> The commit summary could be more specific, for example:
>   Guest Domains: fix code example
>
> but more importantly, it is missing a Sign-off.
> See point 6 at https://libvirt.org/hacking.html#patches
>     Contributors to libvirt projects must assert that they are in
> compliance
>     with the Developer Certificate of Origin 1.1. This is achieved by
> adding
>     a "Signed-off-by" line containing the contributor's name and e-mail to
>     every commit message. The presence of this line attests that the
> contributor
>     has read the above lined DCO and agrees with its statements.
>
> (You can just provide the sign-off in an on-list reply to this e-mail
>  and I will add it to the commit message before pushing)
>

Aah, right. Sorry, I forgot to include the sign-off. I fixed my commit
message. I'm not sure weather I should send the updated patch as
a reply to this e-mail or if I should send a new [PATCH v2] e-mail.
For now I'll go ahead and send a v2 mail, but please let know what I
am supposed to do in such case in the future. I'm new to the process
and trying to get my first tiny patch accepted.

Thanks.


>
> Jano
>
> On Fri, Apr 05, 2019 at 05:58:43PM +0200, Ilias Stamatis wrote:
> >---
> > en-US/Guest_Domains.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/en-US/Guest_Domains.xml b/en-US/Guest_Domains.xml
> >index c15bbb8..2a4ef7c 100644
> >--- a/en-US/Guest_Domains.xml
> >+++ b/en-US/Guest_Domains.xml
> >@@ -88,7 +88,7 @@ dom = virDomainLookupByID(conn, domainID);
> >     <example>
> >       <title>Fetching a domain object from an name</title>
> >       <programlisting>
> >-int domainName = "someguest";
> >+char *domainName = "someguest";
> > virDomainPtr dom;
> >
> > dom = virDomainLookupByName(conn, domainName);
> >--
> >2.21.0
> >
> >--
> >libvir-list mailing list
> >libvir-list@redhat.com
> >https://www.redhat.com/mailman/listinfo/libvir-list
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

Posted by Ján Tomko 5 years ago

On Sat, Apr 06, 2019 at 12:27:09PM +0200, Ilias Stamatis wrote:
>Στις Σάβ, 6 Απρ 2019 στις 10:10 π.μ., ο/η Ján Tomko <jtomko@redhat.com>
>έγραψε:
>
>> The commit summary could be more specific, for example:
>>   Guest Domains: fix code example
>>
>> but more importantly, it is missing a Sign-off.
>> See point 6 at https://libvirt.org/hacking.html#patches
>>     Contributors to libvirt projects must assert that they are in
>> compliance
>>     with the Developer Certificate of Origin 1.1. This is achieved by
>> adding
>>     a "Signed-off-by" line containing the contributor's name and e-mail to
>>     every commit message. The presence of this line attests that the
>> contributor
>>     has read the above lined DCO and agrees with its statements.
>>
>> (You can just provide the sign-off in an on-list reply to this e-mail
>>  and I will add it to the commit message before pushing)
>>
>
>Aah, right. Sorry, I forgot to include the sign-off. I fixed my commit
>message. I'm not sure weather I should send the updated patch as
>a reply to this e-mail or if I should send a new [PATCH v2] e-mail.
>For now I'll go ahead and send a v2 mail, but please let know what I
>am supposed to do in such case in the future.

Patches should be sent using git send-email. That way other
developers can use the usual workflow for saving the patch and applying
it to git. But if the only thing missing is a sign-off, it can be
supplied separately in a non-patch human-readable e-mail.

As for threading, another version of a patch or a patch series should
be a separate thread, as the command on our HACKING page does.

>I'm new to the process
>and trying to get my first tiny patch accepted.
>

Welcome!

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list