mingw: Bump minimum supported Fedora version to 28

[libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

Posted by Andrea Bolognani 5 years ago

Should have been part of 2569ba133822, but clearly wasn't.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 mingw-libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index bea822fd73..8756a56a23 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -3,7 +3,7 @@
 # This spec file assumes you are building on a Fedora version
 # that's still supported by the vendor. It may work on other distros
 # or versions, but no effort will be made to ensure that going forward.
-%define min_fedora 26
+%define min_fedora 28
 
 %if 0%{?fedora} && 0%{?fedora} >= %{min_fedora}
     %define supported_platform 1
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

Posted by Ján Tomko 5 years ago

On Wed, Apr 03, 2019 at 03:47:28PM +0200, Andrea Bolognani wrote:
>Should have been part of 2569ba133822, but clearly wasn't.
>

Self-evidently.

>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> mingw-libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
>index bea822fd73..8756a56a23 100644
>--- a/mingw-libvirt.spec.in
>+++ b/mingw-libvirt.spec.in
>@@ -3,7 +3,7 @@
> # This spec file assumes you are building on a Fedora version
> # that's still supported by the vendor. It may work on other distros
> # or versions, but no effort will be made to ensure that going forward.
>-%define min_fedora 26
>+%define min_fedora 28

This means you can also get rid of the else clause below:
%if 0%{?fedora} >= 27
BuildRequires:  perl-interpreter
%else
BuildRequires:  perl
%endif


Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

Posted by Andrea Bolognani 5 years ago

On Wed, 2019-04-03 at 15:55 +0200, Ján Tomko wrote:
> On Wed, Apr 03, 2019 at 03:47:28PM +0200, Andrea Bolognani wrote:
> > -%define min_fedora 26
> > +%define min_fedora 28
> 
> This means you can also get rid of the else clause below:
> %if 0%{?fedora} >= 27
> BuildRequires:  perl-interpreter
> %else
> BuildRequires:  perl
> %endif

Good catch, I've squashed it in before pushing :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list