build-aux: ensure all scripts are included in EXTRA_DIST

[libvirt] [PATCH] build-aux: ensure all scripts are included in EXTRA_DIST

Posted by Daniel P. Berrangé 5 years ago

Few of the scripts in build-aux are included in EXTRA_DIST. This is not
a serious problem since they are primarily tools intended for developers
upstream, and downstream builds won't need them. Having them missing,
however, complicates downstream patching because it means patches that
are auto-exported from git will fail to apply if they include a change
to a file in build-aux/.  By bundling all these scripts in the dist we
make patching more straightforward.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 Makefile.am | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 621e9b4f89..eba5916352 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -40,7 +40,17 @@ EXTRA_DIST = \
   cfg.mk \
   run.in \
   README.md \
-  AUTHORS.in
+  AUTHORS.in \
+  build-aux/augeas-gentest.pl \
+  build-aux/check-spacing.pl \
+  build-aux/gitlog-to-changelog \
+  build-aux/header-ifdef.pl \
+  build-aux/minimize-po.pl \
+  build-aux/mock-noinline.pl \
+  build-aux/prohibit-duplicate-header.pl \
+  build-aux/useless-if-before-free \
+  build-aux/vc-list-files \
+  $(NULL)
 
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libvirt.pc libvirt-qemu.pc libvirt-lxc.pc libvirt-admin.pc
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] build-aux: ensure all scripts are included in EXTRA_DIST

Posted by Michal Privoznik 5 years ago

On 4/3/19 12:55 PM, Daniel P. Berrangé wrote:
> Few of the scripts in build-aux are included in EXTRA_DIST. This is not
> a serious problem since they are primarily tools intended for developers
> upstream, and downstream builds won't need them. Having them missing,
> however, complicates downstream patching because it means patches that
> are auto-exported from git will fail to apply if they include a change
> to a file in build-aux/.  By bundling all these scripts in the dist we
> make patching more straightforward.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   Makefile.am | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list