On Red Hat variant distros ca-certificates gets pulled in
automatically by other packages we require. This doesn't
happen on Debian and so any use of https URIs fails. This
prevents git from cloning submodules over https.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 guests/vars/mappings.yml      | 4 ++++
 guests/vars/projects/base.yml | 1 +
 2 files changed, 5 insertions(+)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 50f07fa..b369c0a 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -99,6 +99,10 @@ mappings:
   bash-completion:
     default: bash-completion
 
+  ca-certificates:
+    default: ca-certificates
+    FreeBSD:
+
   ccache:
     default: ccache
     CentOS:
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index b3d1d47..a7e572b 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars/projects/base.yml
@@ -5,6 +5,7 @@ packages:
   - autopoint
   - bash
   - bash-completion
+  - ca-certificates
   - ccache
   - chrony
   - cppi
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2019-04-03 at 11:23 +0100, Daniel P. Berrangé wrote:
> On Red Hat variant distros ca-certificates gets pulled in
> automatically by other packages we require. This doesn't
> happen on Debian and so any use of https URIs fails. This
> prevents git from cloning submodules over https.

All the Debian and Ubuntu guests that I have created with lcitool
have the package installed, but I see it's not present in (for
example) the Debian 9 container, possibly as a consequence of
using --no-install-recommends. Either way, we do want the package
to be there and there's no harm in installing it explicitly.

[...]
> +  ca-certificates:
> +    default: ca-certificates
> +    FreeBSD:

FreeBSD uses a different name for the package (ca_root_nss), but
other than that it should still be the very same contents.

With the FreeBSD package added,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list