mingw: unconditionally enable libssh2 in RPM

[libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM

Daniel P. Berrangé posted 1 patch 5 years ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190403101816.31157-1-berrange@redhat.com

mingw-libvirt.spec.in | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM

Posted by Daniel P. Berrangé 5 years ago

The libssh2 support in libvirt is not solely for phyp, it is used by the
remote driver too.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 mingw-libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index 9983a5013f..913aaa8751 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -85,10 +85,8 @@ BuildRequires: gettext-devel
 BuildRequires: libtool
 %endif
 
-%if %{with_phyp}
 BuildRequires: mingw32-libssh2
 BuildRequires: mingw64-libssh2
-%endif
 %if %{with_esx}
 BuildRequires: mingw32-curl
 BuildRequires: mingw64-curl
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM

Posted by Andrea Bolognani 5 years ago

On Wed, 2019-04-03 at 11:18 +0100, Daniel P. Berrangé wrote:
> The libssh2 support in libvirt is not solely for phyp, it is used by the
> remote driver too.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  mingw-libvirt.spec.in | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list