[libvirt] [PATCH 0/4] Fix various test portability problems

Daniel P. Berrangé posted 4 patches 5 years ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190402124036.2415-1-berrange@redhat.com
build-aux/mock-noinline.pl      |   3 +
cfg.mk                          |  20 +-
src/qemu/qemu_firmware.c        |  12 +-
src/security/security_selinux.c |   6 +-
tests/Makefile.am               |   1 +
tests/qemusecuritymock.c        | 131 ++++---------
tests/vircgroupmock.c           | 146 ++------------
tests/virfilewrapper.c          |  85 ++-------
tests/virmock.h                 |  11 --
tests/virmockstathelpers.c      | 326 ++++++++++++++++++++++++++++++++
tests/virpcimock.c              |  93 +--------
tests/virtestmock.c             | 140 +-------------
12 files changed, 440 insertions(+), 534 deletions(-)
create mode 100644 tests/virmockstathelpers.c
[libvirt] [PATCH 0/4] Fix various test portability problems
Posted by Daniel P. Berrangé 5 years ago
This includes a slight tweak to the stat/lstat patch wrt logging and
fixes use of the dirent d_type field.

Daniel P. Berrangé (4):
  tests: fix mocking of stat() / lstat() functions
  qemu: don't rely on the non-portable d_type field in dirent
  security: avoid use of dirent d_type field
  cfg.mk: block use of d_type from dirent by default

 build-aux/mock-noinline.pl      |   3 +
 cfg.mk                          |  20 +-
 src/qemu/qemu_firmware.c        |  12 +-
 src/security/security_selinux.c |   6 +-
 tests/Makefile.am               |   1 +
 tests/qemusecuritymock.c        | 131 ++++---------
 tests/vircgroupmock.c           | 146 ++------------
 tests/virfilewrapper.c          |  85 ++-------
 tests/virmock.h                 |  11 --
 tests/virmockstathelpers.c      | 326 ++++++++++++++++++++++++++++++++
 tests/virpcimock.c              |  93 +--------
 tests/virtestmock.c             | 140 +-------------
 12 files changed, 440 insertions(+), 534 deletions(-)
 create mode 100644 tests/virmockstathelpers.c

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Fix various test portability problems
Posted by Michal Privoznik 5 years ago
On 4/2/19 2:40 PM, Daniel P. Berrangé wrote:
> This includes a slight tweak to the stat/lstat patch wrt logging and
> fixes use of the dirent d_type field.
> 
> Daniel P. Berrangé (4):
>    tests: fix mocking of stat() / lstat() functions
>    qemu: don't rely on the non-portable d_type field in dirent
>    security: avoid use of dirent d_type field
>    cfg.mk: block use of d_type from dirent by default
> 
>   build-aux/mock-noinline.pl      |   3 +
>   cfg.mk                          |  20 +-
>   src/qemu/qemu_firmware.c        |  12 +-
>   src/security/security_selinux.c |   6 +-
>   tests/Makefile.am               |   1 +
>   tests/qemusecuritymock.c        | 131 ++++---------
>   tests/vircgroupmock.c           | 146 ++------------
>   tests/virfilewrapper.c          |  85 ++-------
>   tests/virmock.h                 |  11 --
>   tests/virmockstathelpers.c      | 326 ++++++++++++++++++++++++++++++++
>   tests/virpcimock.c              |  93 +--------
>   tests/virtestmock.c             | 140 +-------------
>   12 files changed, 440 insertions(+), 534 deletions(-)
>   create mode 100644 tests/virmockstathelpers.c
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list