[libvirt] [PATCH 0/5] examples: enforce compiler warning flags

Daniel P. Berrangé posted 5 patches 5 years ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190402100211.2252-1-berrange@redhat.com
examples/Makefile.am               |  3 ++-
examples/admin/client_info.c       |  7 ++++---
examples/admin/client_limits.c     |  2 +-
examples/admin/list_clients.c      |  3 ++-
examples/admin/threadpool_params.c |  2 +-
examples/dominfo/info1.c           | 25 ++++++++++++++-----------
examples/domtop/domtop.c           | 13 ++++++++-----
7 files changed, 32 insertions(+), 23 deletions(-)
[libvirt] [PATCH 0/5] examples: enforce compiler warning flags
Posted by Daniel P. Berrangé 5 years ago
The example programs emitted a number of warnings even without having
the WARN_CFLAGS set. Once they were set a bunch more flaws came to
light. Fix them all and enforce warnings so that the example programs
are higher quality code.

Daniel P. Berrangé (5):
  examples: fix 64-bit integer formatting on Windows
  examples: avoid goto jump over initialization of variable
  domtop: remove unused domain name parameter
  dominfo: make example more useful
  examples: enable all compiler warnings

 examples/Makefile.am               |  3 ++-
 examples/admin/client_info.c       |  7 ++++---
 examples/admin/client_limits.c     |  2 +-
 examples/admin/list_clients.c      |  3 ++-
 examples/admin/threadpool_params.c |  2 +-
 examples/dominfo/info1.c           | 25 ++++++++++++++-----------
 examples/domtop/domtop.c           | 13 ++++++++-----
 7 files changed, 32 insertions(+), 23 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] examples: enforce compiler warning flags
Posted by Ján Tomko 5 years ago
On Tue, Apr 02, 2019 at 11:02:06AM +0100, Daniel P. Berrangé wrote:
>The example programs emitted a number of warnings even without having
>the WARN_CFLAGS set. Once they were set a bunch more flaws came to
>light. Fix them all and enforce warnings so that the example programs
>are higher quality code.
>
>Daniel P. Berrangé (5):
>  examples: fix 64-bit integer formatting on Windows
>  examples: avoid goto jump over initialization of variable
>  domtop: remove unused domain name parameter
>  dominfo: make example more useful
>  examples: enable all compiler warnings
>
> examples/Makefile.am               |  3 ++-
> examples/admin/client_info.c       |  7 ++++---
> examples/admin/client_limits.c     |  2 +-
> examples/admin/list_clients.c      |  3 ++-
> examples/admin/threadpool_params.c |  2 +-
> examples/dominfo/info1.c           | 25 ++++++++++++++-----------
> examples/domtop/domtop.c           | 13 ++++++++-----
> 7 files changed, 32 insertions(+), 23 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list