[libvirt] [PATCH] virsh.pod: Improve native configuration format doc

Han Han posted 1 patch 5 years ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190328040646.6747-1-hhan@redhat.com
tools/virsh.pod | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
[libvirt] [PATCH] virsh.pod: Improve native configuration format doc
Posted by Han Han 5 years ago
Add native guest format of BSD hypervisor and VMware/ESX. Quote native
guest format of domxml-from-native for domxml-to-native.

Signed-off-by: Han Han <hhan@redhat.com>
---
 tools/virsh.pod | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index a0fe949c55..b3819b9414 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1607,21 +1607,17 @@ Convert the file I<config> in the native guest configuration format
 named by I<format> to a domain XML format. For QEMU/KVM hypervisor,
 the I<format> argument must be B<qemu-argv>. For Xen hypervisor, the
 I<format> argument may be B<xen-xm>, B<xen-xl>, or B<xen-sxpr>. For
-LXC hypervisor, the I<format> argument must be B<lxc-tools>.
+LXC hypervisor, the I<format> argument must be B<lxc-tools>. For
+VMware/ESX hypervisor, the I<format> argument must be B<vmware-vmx>.
+For the BSD hypervisor, the I<format> argument must be B<bhyve-argv>.
 
 =item B<domxml-to-native> I<format>
 { [I<--xml>] I<xml> | I<--domain> I<domain-name-or-id-or-uuid> }
 
 Convert the file I<xml> into domain XML format or convert an existing
 I<--domain> to the native guest configuration format named by I<format>.
-The I<xml> and I<--domain> arguments are mutually exclusive.
-
-For the QEMU/KVM hypervisor, the I<format> argument must be B<qemu-argv>.
-
-For the Xen hypervisor, the I<format> argument may be B<xen-xm>, B<xen-xl>,
-or B<xen-sxpr>.
-
-For the LXC hypervisor, the I<format> argument must be B<lxc-tools>.
+The I<xml> and I<--domain> arguments are mutually exclusive. For the types
+of I<format> argument, refer to B<domxml-from-native>.
 
 =item B<dump> I<domain> I<corefilepath> [I<--bypass-cache>]
 { [I<--live>] | [I<--crash>] | [I<--reset>] } [I<--verbose>] [I<--memory-only>]
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virsh.pod: Improve native configuration format doc
Posted by Cole Robinson 5 years ago
On 3/28/19 12:06 AM, Han Han wrote:
> Add native guest format of BSD hypervisor and VMware/ESX. Quote native
> guest format of domxml-from-native for domxml-to-native.
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  tools/virsh.pod | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index a0fe949c55..b3819b9414 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1607,21 +1607,17 @@ Convert the file I<config> in the native guest configuration format
>  named by I<format> to a domain XML format. For QEMU/KVM hypervisor,
>  the I<format> argument must be B<qemu-argv>. For Xen hypervisor, the
>  I<format> argument may be B<xen-xm>, B<xen-xl>, or B<xen-sxpr>. For
> -LXC hypervisor, the I<format> argument must be B<lxc-tools>.
> +LXC hypervisor, the I<format> argument must be B<lxc-tools>. For
> +VMware/ESX hypervisor, the I<format> argument must be B<vmware-vmx>.
> +For the BSD hypervisor, the I<format> argument must be B<bhyve-argv>.
>  

I replaced BSD with 'Bhyve' which is the string we print from 'virsh
version' for bhyve connections. Pushed now

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list