1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] tools: Tweak workding for iothreadset

John Ferlan posted 1 patch 5 years ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190327203812.6679-1-jferlan@redhat.com
tools/virsh.pod | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[libvirt] [PATCH] tools: Tweak workding for iothreadset
Posted by John Ferlan 5 years ago 
Update the wording to note the values for polling are purely dynamic
and won't be saved across domain stop/(re)start or save/restore.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 tools/virsh.pod | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index a0fe949c55..f00564fa5f 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1772,7 +1772,10 @@ reach the maximum polling time. If a 0 (zero) is provided, then the
 default factor will be used. The I<--poll-shrink> is the quotient
 by which the current polling time will be reduced in order to get
 below the maximum polling interval. If a 0 (zero) is provided, then
-the default quotient will be used.
+the default quotient will be used. The polling values are purely dynamic
+for a running guest. Saving, destroying, stopping, etc. the guest will
+result in the polling values returning to hypervisor defaults at the
+next start, restore, etc.
 
 If I<--live> is specified, affect a running guest. If the guest is not
 running an error is returned.
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tools: Tweak workding for iothreadset
Posted by Laine Stump 5 years ago 
On 3/27/19 4:38 PM, John Ferlan wrote:
> tools: Tweak workding for iothreadset


s/workding/wording/ :-)


> Update the wording to note the values for polling are purely dynamic
>
> and won't be saved across domain stop/(re)start or save/restore.


What about migration?


Reviewed-by: Laine Stump <laine@laine.org>


>
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>   tools/virsh.pod | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index a0fe949c55..f00564fa5f 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1772,7 +1772,10 @@ reach the maximum polling time. If a 0 (zero) is provided, then the
>   default factor will be used. The I<--poll-shrink> is the quotient
>   by which the current polling time will be reduced in order to get
>   below the maximum polling interval. If a 0 (zero) is provided, then
> -the default quotient will be used.
> +the default quotient will be used. The polling values are purely dynamic
> +for a running guest. Saving, destroying, stopping, etc. the guest will
> +result in the polling values returning to hypervisor defaults at the
> +next start, restore, etc.
>   
>   If I<--live> is specified, affect a running guest. If the guest is not
>   running an error is returned.


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tools: Tweak workding for iothreadset
Posted by John Ferlan 5 years ago 

On 3/27/19 4:58 PM, Laine Stump wrote:
> On 3/27/19 4:38 PM, John Ferlan wrote:
>> tools: Tweak workding for iothreadset
> 
> 
> s/workding/wording/ :-)
> 
> 
>> Update the wording to note the values for polling are purely dynamic
>>
>> and won't be saved across domain stop/(re)start or save/restore.
> 
> 
> What about migration?
> 

etc. ;-)

I started thinking about that while typing and played loose with the
workding ;-) to CMA.

Still, in order to be truly copied one would have to take the running
qemu image and move it elsewhere. The answer may be in how/where the
value is stored in qemu and/or memory that would be copied for a live
migration. IOW: on the target does qemu start the guest using whatever
configuration was "figured out" on the source including any kind of
parameter changes that could occur without libvirt's involvement. It's
far too late in my day to think about those details. I'll wait to see if
anyone else comments about it.

Tks -

John

> 
> Reviewed-by: Laine Stump <laine@laine.org>
> 
> 
>>
>> Signed-off-by: John Ferlan <jferlan@redhat.com>
>> ---
>>   tools/virsh.pod | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/virsh.pod b/tools/virsh.pod
>> index a0fe949c55..f00564fa5f 100644
>> --- a/tools/virsh.pod
>> +++ b/tools/virsh.pod
>> @@ -1772,7 +1772,10 @@ reach the maximum polling time. If a 0 (zero)
>> is provided, then the
>>   default factor will be used. The I<--poll-shrink> is the quotient
>>   by which the current polling time will be reduced in order to get
>>   below the maximum polling interval. If a 0 (zero) is provided, then
>> -the default quotient will be used.
>> +the default quotient will be used. The polling values are purely dynamic
>> +for a running guest. Saving, destroying, stopping, etc. the guest will
>> +result in the polling values returning to hypervisor defaults at the
>> +next start, restore, etc.
>>     If I<--live> is specified, affect a running guest. If the guest is
>> not
>>   running an error is returned.
> 
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.