[libvirt] [PATCH] spec: Move ldconfig calls from -client to -libs

Andrea Bolognani posted 1 patch 11 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190325095924.28633-1-abologna@redhat.com
libvirt.spec.in | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)

[libvirt] [PATCH] spec: Move ldconfig calls from -client to -libs

Posted by Andrea Bolognani 11 weeks ago
ldconfig needs to be called after installing or uninstalling
shared libraries.

For a very long time, libvirt didn't have a separate package
containing just the shared libraries, and so it shipped them
in the same one as the clients.

Since commit 70b4f0e719cd, however, shared libraries have been
moved from -client to their own -libs package; unfortunately,
the corresponding ldconfig calls were not moved at the same
time, which is what this commit takes care of.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index b7a35a0fb1..8ea27c91a3 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1328,6 +1328,16 @@ then
   exit 1
 fi
 
+%post libs
+%if 0%{?rhel} == 7
+/sbin/ldconfig
+%endif
+
+%postun libs
+%if 0%{?rhel} == 7
+/sbin/ldconfig
+%endif
+
 %pre daemon
 # 'libvirt' group is just to allow password-less polkit access to
 # libvirtd. The uid number is irrelevant, so we use dynamic allocation
@@ -1469,17 +1479,9 @@ exit 0
 %systemd_preun libvirt-guests.service
 
 %post client
-
-%if 0%{?rhel} == 7
-/sbin/ldconfig
-%endif
 %systemd_post libvirt-guests.service
 
 %postun client
-
-%if 0%{?rhel} == 7
-/sbin/ldconfig
-%endif
 %systemd_postun libvirt-guests.service
 
 %if %{with_sanlock}
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Move ldconfig calls from -client to -libs

Posted by Jiri Denemark 11 weeks ago
On Mon, Mar 25, 2019 at 10:59:24 +0100, Andrea Bolognani wrote:
> ldconfig needs to be called after installing or uninstalling
> shared libraries.
> 
> For a very long time, libvirt didn't have a separate package
> containing just the shared libraries, and so it shipped them
> in the same one as the clients.
> 
> Since commit 70b4f0e719cd, however, shared libraries have been
> moved from -client to their own -libs package; unfortunately,
> the corresponding ldconfig calls were not moved at the same
> time, which is what this commit takes care of.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list