[libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Daniel P. Berrangé posted 1 patch 9 weeks ago
Failed in applying to current master (apply log)
jenkins/jobs/autotools.yaml        | 8 ++++----
jenkins/jobs/generic.yaml          | 8 ++++----
jenkins/jobs/go.yaml               | 4 ++--
jenkins/jobs/perl-modulebuild.yaml | 6 +++---
jenkins/jobs/python-distutils.yaml | 6 +++---
5 files changed, 16 insertions(+), 16 deletions(-)

[libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Posted by Daniel P. Berrangé 9 weeks ago
The current config causes jenkins to send a build on every single
failure. This is way too noisy so change it to only send emails on
the transition from good to bad.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 jenkins/jobs/autotools.yaml        | 8 ++++----
 jenkins/jobs/generic.yaml          | 8 ++++----
 jenkins/jobs/go.yaml               | 4 ++--
 jenkins/jobs/perl-modulebuild.yaml | 6 +++---
 jenkins/jobs/python-distutils.yaml | 6 +++---
 5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/jenkins/jobs/autotools.yaml b/jenkins/jobs/autotools.yaml
index e365ec4..f04ec17 100644
--- a/jenkins/jobs/autotools.yaml
+++ b/jenkins/jobs/autotools.yaml
@@ -50,7 +50,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -89,7 +89,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -132,7 +132,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -174,5 +174,5 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
diff --git a/jenkins/jobs/generic.yaml b/jenkins/jobs/generic.yaml
index 1990930..ca69513 100644
--- a/jenkins/jobs/generic.yaml
+++ b/jenkins/jobs/generic.yaml
@@ -45,7 +45,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -83,7 +83,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -121,7 +121,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -159,5 +159,5 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
diff --git a/jenkins/jobs/go.yaml b/jenkins/jobs/go.yaml
index 3c14c35..1bdcb5f 100644
--- a/jenkins/jobs/go.yaml
+++ b/jenkins/jobs/go.yaml
@@ -45,7 +45,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -83,5 +83,5 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
diff --git a/jenkins/jobs/perl-modulebuild.yaml b/jenkins/jobs/perl-modulebuild.yaml
index 933020a..7173493 100644
--- a/jenkins/jobs/perl-modulebuild.yaml
+++ b/jenkins/jobs/perl-modulebuild.yaml
@@ -47,7 +47,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 
@@ -86,7 +86,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -127,5 +127,5 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
diff --git a/jenkins/jobs/python-distutils.yaml b/jenkins/jobs/python-distutils.yaml
index 6b388f2..f56794c 100644
--- a/jenkins/jobs/python-distutils.yaml
+++ b/jenkins/jobs/python-distutils.yaml
@@ -47,7 +47,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 
@@ -86,7 +86,7 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
 
 - job-template:
@@ -127,5 +127,5 @@
     publishers:
       - email:
           recipients: '{obj:spam}'
-          notify-every-unstable-build: true
+          notify-every-unstable-build: false
           send-to-individuals: false
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Posted by Daniel P. Berrangé 7 weeks ago
On Thu, Mar 14, 2019 at 05:25:13PM +0000, Daniel P. Berrangé wrote:
> The current config causes jenkins to send a build on every single
> failure. This is way too noisy so change it to only send emails on
> the transition from good to bad.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  jenkins/jobs/autotools.yaml        | 8 ++++----
>  jenkins/jobs/generic.yaml          | 8 ++++----
>  jenkins/jobs/go.yaml               | 4 ++--
>  jenkins/jobs/perl-modulebuild.yaml | 6 +++---
>  jenkins/jobs/python-distutils.yaml | 6 +++---
>  5 files changed, 16 insertions(+), 16 deletions(-)

So this is pushed, and applied to the jenkins server, but it is still
sending emails on every failed build. Guess this setting doesn't
really do what it is documented todo :-(


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Posted by Erik Skultety 7 weeks ago
On Thu, Mar 28, 2019 at 10:29:53AM +0000, Daniel P. Berrangé wrote:
> On Thu, Mar 14, 2019 at 05:25:13PM +0000, Daniel P. Berrangé wrote:
> > The current config causes jenkins to send a build on every single
> > failure. This is way too noisy so change it to only send emails on
> > the transition from good to bad.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  jenkins/jobs/autotools.yaml        | 8 ++++----
> >  jenkins/jobs/generic.yaml          | 8 ++++----
> >  jenkins/jobs/go.yaml               | 4 ++--
> >  jenkins/jobs/perl-modulebuild.yaml | 6 +++---
> >  jenkins/jobs/python-distutils.yaml | 6 +++---
> >  5 files changed, 16 insertions(+), 16 deletions(-)
>
> So this is pushed, and applied to the jenkins server, but it is still
> sending emails on every failed build. Guess this setting doesn't
> really do what it is documented todo :-(

Sigh...I haven't noticed earlier, the problem is terminology
failed vs unstable, so according to jenkins it works as expected and they don't
seem to have anything alike for failed builds.
Honestly reading the wiki on what an unstable build is, I'm still not sure I
understand it.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Posted by Erik Skultety 7 weeks ago
On Thu, Mar 28, 2019 at 04:51:55PM +0100, Erik Skultety wrote:
> On Thu, Mar 28, 2019 at 10:29:53AM +0000, Daniel P. Berrangé wrote:
> > On Thu, Mar 14, 2019 at 05:25:13PM +0000, Daniel P. Berrangé wrote:
> > > The current config causes jenkins to send a build on every single
> > > failure. This is way too noisy so change it to only send emails on
> > > the transition from good to bad.
> > >
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > ---
> > >  jenkins/jobs/autotools.yaml        | 8 ++++----
> > >  jenkins/jobs/generic.yaml          | 8 ++++----
> > >  jenkins/jobs/go.yaml               | 4 ++--
> > >  jenkins/jobs/perl-modulebuild.yaml | 6 +++---
> > >  jenkins/jobs/python-distutils.yaml | 6 +++---
> > >  5 files changed, 16 insertions(+), 16 deletions(-)
> >
> > So this is pushed, and applied to the jenkins server, but it is still
> > sending emails on every failed build. Guess this setting doesn't
> > really do what it is documented todo :-(
>
> Sigh...I haven't noticed earlier, the problem is terminology
> failed vs unstable, so according to jenkins it works as expected and they don't
> seem to have anything alike for failed builds.
> Honestly reading the wiki on what an unstable build is, I'm still not sure I
> understand it.
>
> Erik

There is a plugin though which might be able to open further options to us, but
I don't know how I'd try it, any suggestions?

https://wiki.jenkins.io/display/JENKINS/Email-ext+plugin

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure

Posted by Erik Skultety 9 weeks ago
On Thu, Mar 14, 2019 at 05:25:13PM +0000, Daniel P. Berrangé wrote:
> The current config causes jenkins to send a build on every single
> failure. This is way too noisy so change it to only send emails on
> the transition from good to bad.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list