[v1] Add function for XML yes|no string handling

[libvirt] [PATCH 0/2] Add function for XML yes|no string handling

Shotaro Gotanda posted 2 patches 5 years, 8 months ago

Diff against v2 v3
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190311153806.31327-1-g.sho1500@gmail.com

There is a newer version of this series

src/conf/domain_conf.c | 30 +++++-------------------------
src/conf/secret_conf.c | 12 ++----------
src/util/virstring.c   | 32 ++++++++++++++++++++++++++++++++
src/util/virstring.h   |  3 +++
4 files changed, 42 insertions(+), 35 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Add function for XML yes|no string handling

Posted by Shotaro Gotanda 5 years, 8 months ago

These patches are based on a bite-sized task proposed in
https://wiki.libvirt.org/page/BiteSizedTasks
and the mentor of this bite-sized task is Cole Robinson
<crobinso@redhat.com>
(Do I need to put the mentor in cc, in this case?)

The function virStringParseYesNo() convert the string "yes" into bool
true and "no" into false, and error if we receive anything other than
those values.

To be honest, I'm not confident on the error handling in libvirt.
So, please check that point.

Regards,
Shotaro

Shotaro Gotanda (2):
  util: add virStringParseYesNo()
  conf: Use virStringParseYesNo()

 src/conf/domain_conf.c | 30 +++++-------------------------
 src/conf/secret_conf.c | 12 ++----------
 src/util/virstring.c   | 32 ++++++++++++++++++++++++++++++++
 src/util/virstring.h   |  3 +++
 4 files changed, 42 insertions(+), 35 deletions(-)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list