rpm: add dep on xfsprogs-devel for reflink support

[libvirt] [PATCH] rpm: add dep on xfsprogs-devel for reflink support

Posted by Daniel P. Berrangé 5 years, 1 month ago

Support for XFS reflink clone was added in:

  commit 8ed874b39b3c330bbcdff434e08995dbb4467285
  Author: Julio Faracco <jcfaracco@gmail.com>
  Date:   Fri Jul 6 10:43:01 2018 -0300

    storage: Rename btrfsCloneFile to support other filesystems.

  commit 2e11298f938672c5430193277c98b9474a68b1fb
  Author: Julio Faracco <jcfaracco@gmail.com>
  Date:   Fri Jul 6 10:43:00 2018 -0300

    configure: Adding XFS library/headers check.

But these patches missed that the xfs/xfs.h header is not installed
unless you have xfsprogs-devel present.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 9beffba203..83b43f4ef6 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -326,6 +326,8 @@ BuildRequires: libiscsi-devel
 BuildRequires: parted-devel
 # For Multipath support
 BuildRequires: device-mapper-devel
+# For XFS reflink clone support
+BuildRequires: xfsprogs-devel
 %if %{with_storage_rbd}
 BuildRequires: librados2-devel
 BuildRequires: librbd1-devel
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] rpm: add dep on xfsprogs-devel for reflink support

Posted by Andrea Bolognani 5 years, 1 month ago

On Wed, 2019-03-06 at 09:28 +0000, Daniel P. Berrangé wrote:
> Support for XFS reflink clone was added in:
> 
>   commit 8ed874b39b3c330bbcdff434e08995dbb4467285
>   Author: Julio Faracco <jcfaracco@gmail.com>
>   Date:   Fri Jul 6 10:43:01 2018 -0300
> 
>     storage: Rename btrfsCloneFile to support other filesystems.
> 
>   commit 2e11298f938672c5430193277c98b9474a68b1fb
>   Author: Julio Faracco <jcfaracco@gmail.com>
>   Date:   Fri Jul 6 10:43:00 2018 -0300
> 
>     configure: Adding XFS library/headers check.
> 
> But these patches missed that the xfs/xfs.h header is not installed
> unless you have xfsprogs-devel present.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list