On Thu, Feb 28, 2019 at 05:38:47PM +0100, Andrea Bolognani wrote:
>Some test cases are only executed using WHEN_INACTIVE, and the
>output file name should reflect this for clarity.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
>I'm actually not entirely convinced I prefer having the -inactive
>suffix for these files, but I figured I'd still post the patch and
>see what other people think :)
>
I think that a certain combination of DO_TEST parameters should
unambiguously map to test filenames, i.e. no usage of virFileExists
when we fill out the filenames.
And making these asymetric tests stand out against the WHEN_BOTH tests
with identical outputs looks better to me.
But for identical outputs, I think we're better off reintroducing the
DO_TEST_DIFFERENT macro instead of encoding the info whether the outputs
are the same in the filesystem.
> ...amic-baselabel.xml => seclabel-dynamic-baselabel-inactive.xml} | 0
> ...amic-labelskip.xml => seclabel-dynamic-labelskip-inactive.xml} | 0
> ...one-relabel.xml => seclabel-dynamic-none-relabel-inactive.xml} | 0
> ...ynamic-override.xml => seclabel-dynamic-override-inactive.xml} | 0
> ...-dynamic-relabel.xml => seclabel-dynamic-relabel-inactive.xml} | 0
> 5 files changed, 0 insertions(+), 0 deletions(-)
> rename tests/qemuxml2xmloutdata/{seclabel-dynamic-baselabel.xml => seclabel-dynamic-baselabel-inactive.xml} (100%)
> rename tests/qemuxml2xmloutdata/{seclabel-dynamic-labelskip.xml => seclabel-dynamic-labelskip-inactive.xml} (100%)
> rename tests/qemuxml2xmloutdata/{seclabel-dynamic-none-relabel.xml => seclabel-dynamic-none-relabel-inactive.xml} (100%)
> rename tests/qemuxml2xmloutdata/{seclabel-dynamic-override.xml => seclabel-dynamic-override-inactive.xml} (100%)
> rename tests/qemuxml2xmloutdata/{seclabel-dynamic-relabel.xml => seclabel-dynamic-relabel-inactive.xml} (100%)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list