Don't set a default value for ostype

[libvirt] [tck PATCH] Don't set a default value for ostype

Posted by Daniel P. Berrangé 6 years, 11 months ago

We must leave ostype undefined by default so that we can auto-detect the
right ostype based on reported capabilities. This fixes the ability to
run tests with the LXC driver previously broken in

  commit c1af9677491d41c8d7a6cc741674e234796de6d0
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Thu Mar 27 11:57:14 2014 +0000

    Change 'Sys::Virt::TCK::generic_domain' to take named params

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 lib/Sys/Virt/TCK.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
index f715ee1..389d5cc 100644
--- a/lib/Sys/Virt/TCK.pm
+++ b/lib/Sys/Virt/TCK.pm
@@ -919,7 +919,7 @@ sub generic_domain {
     my %params = @_;
 
     my $name = exists $params{name} ? $params{name} : "tck";
-    my $ostype = exists $params{ostype} ? $params{ostype} : "hvm";
+    my $ostype = exists $params{ostype} ? $params{ostype} : undef;
     my $fullos = exists $params{fullos} ? $params{fullos} : 0;
     my $netmode = exists $params{netmode} ? $params{netmode} : undef;
     my $shareddisk = exists $params{shareddisk} ? $params{shareddisk} : 0;
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [tck PATCH] Don't set a default value for ostype

Posted by Laine Stump 6 years, 11 months ago

On 2/26/19 1:07 PM, Daniel P. Berrangé wrote:
> We must leave ostype undefined by default so that we can auto-detect the
> right ostype based on reported capabilities. This fixes the ability to
> run tests with the LXC driver previously broken in
>
>    commit c1af9677491d41c8d7a6cc741674e234796de6d0
>    Author: Daniel P. Berrange <berrange@redhat.com>
>    Date:   Thu Mar 27 11:57:14 2014 +0000
>
>      Change 'Sys::Virt::TCK::generic_domain' to take named params
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


Reviewed-by: Laine Stump <laine@laine.org>


> ---
>   lib/Sys/Virt/TCK.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
> index f715ee1..389d5cc 100644
> --- a/lib/Sys/Virt/TCK.pm
> +++ b/lib/Sys/Virt/TCK.pm
> @@ -919,7 +919,7 @@ sub generic_domain {
>       my %params = @_;
>   
>       my $name = exists $params{name} ? $params{name} : "tck";
> -    my $ostype = exists $params{ostype} ? $params{ostype} : "hvm";
> +    my $ostype = exists $params{ostype} ? $params{ostype} : undef;
>       my $fullos = exists $params{fullos} ? $params{fullos} : 0;
>       my $netmode = exists $params{netmode} ? $params{netmode} : undef;
>       my $shareddisk = exists $params{shareddisk} ? $params{shareddisk} : 0;


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list