src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+)
it looks sensible that the copyright notice on the affected files in updated as in this patch so as to also cover another party who hugely participated in writing the code. David Kiarie (1): src/xenconfig: update copyright notice src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
> it looks sensible that the copyright notice on the affected files in
> updated as in this patch so as to also cover another party who hugely
> participated in writing the code.
I must point out that you specifically asked us to remove your name
from the files:
https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html
Which was fulfilled after the discussion in the thread above by:
https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html
And now lives in the repo as:
commit d894e49292ae5135b6a9f44a634b5cfca4376f19
Author: David Kiarie <davidkiarie4@gmail.com>
Date: Tue May 8 15:40:00 2018 +0300
xenconfig: remove my name and email from files
Did you change your mind?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > it looks sensible that the copyright notice on the affected files in > > updated as in this patch so as to also cover another party who hugely > > participated in writing the code. > > I must point out that you specifically asked us to remove your name > from the files: > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > > Which was fulfilled after the discussion in the thread above by: > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > And now lives in the repo as: > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 > Author: David Kiarie <davidkiarie4@gmail.com> > Date: Tue May 8 15:40:00 2018 +0300 > > xenconfig: remove my name and email from files > > > Did you change your mind? Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to add your name into a Copyright line now. Only SUSE was mentioned as the copyright holder when you created the files. This makes me think you might have contributed this as part of your contract with SUSE in which case you are most likely not the copyright holder (even though you didn't use a @suse.com email, but that's not rare some people just keep using their personal email). Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> wrote: > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > > it looks sensible that the copyright notice on the affected files in > > > updated as in this patch so as to also cover another party who hugely > > > participated in writing the code. > > > > I must point out that you specifically asked us to remove your name > > from the files: > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > > > > Which was fulfilled after the discussion in the thread above by: > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > And now lives in the repo as: > > > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 > > Author: David Kiarie <davidkiarie4@gmail.com> > > Date: Tue May 8 15:40:00 2018 +0300 > > > > xenconfig: remove my name and email from files > > > > > > Did you change your mind? > yes, i will actually share the copyright, if possible. > > Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to > add your name into a Copyright line now. Only SUSE was mentioned as the > copyright holder when you created the files. This makes me think you > might have contributed this as part of your contract with SUSE in which > case you are most likely not the copyright holder (even though you > didn't use a @suse.com email, but that's not rare some people just keep > using their personal email). > i did this as part of GSoC. there was no contract. i think an email is personal enough that it shouldn't appear on copyright notice just like i can't have my phone number on the copyright declaration. > > Jirka > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:42 AM David Kiarie <davidkiarie4@gmail.com> wrote: > > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> > wrote: > >> On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: >> > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: >> > > it looks sensible that the copyright notice on the affected files in >> > > updated as in this patch so as to also cover another party who hugely >> > > participated in writing the code. >> > >> > I must point out that you specifically asked us to remove your name >> > from the files: >> > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html >> > >> > Which was fulfilled after the discussion in the thread above by: >> > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > as you can see, this request was fulfilled within minutes, mostly because Daniel is bitter that i tried to use a pseudonym on the code but he strangely has nothing to say to say this time round. > >> > >> > And now lives in the repo as: >> > >> > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 >> > Author: David Kiarie <davidkiarie4@gmail.com> >> > Date: Tue May 8 15:40:00 2018 +0300 >> > >> > xenconfig: remove my name and email from files >> > >> > >> > Did you change your mind? >> > > yes, i will actually share the copyright, if possible. > > >> >> Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to >> add your name into a Copyright line now. Only SUSE was mentioned as the >> copyright holder when you created the files. This makes me think you >> might have contributed this as part of your contract with SUSE in which >> case you are most likely not the copyright holder (even though you >> didn't use a @suse.com email, but that's not rare some people just keep >> using their personal email). >> > > i did this as part of GSoC. there was no contract. > > i think an email is personal enough that it shouldn't appear on copyright > notice just like i can't have my phone number on the copyright declaration. > > >> >> Jirka >> > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:49:57AM +0300, David Kiarie wrote: > On Fri, Feb 22, 2019 at 11:42 AM David Kiarie <davidkiarie4@gmail.com> > wrote: > > > > > > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> > > wrote: > > > >> On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > >> > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > >> > > it looks sensible that the copyright notice on the affected files in > >> > > updated as in this patch so as to also cover another party who hugely > >> > > participated in writing the code. > >> > > >> > I must point out that you specifically asked us to remove your name > >> > from the files: > >> > > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > >> > > >> > Which was fulfilled after the discussion in the thread above by: > >> > > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > > as you can see, this request was fulfilled within minutes, mostly because > Daniel is bitter that i tried to use a pseudonym on the code but he > strangely has nothing to say to say this time round. I think that any attempt to convert this conversation to personal matters involving feelings and emotions is unacceptable on any kind of technical mailing list both open source or closed source. I'm sure you can understand that people have different working hours from different time zones and have many pressing issues originating from dozens of mailing lists to focus on to keep our open source mission rolling. We are very serious about open source (every project should for that matter) and this *should* not become a playground arguing about authorships. Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
> > > as you can see, this request was fulfilled within minutes, mostly because > > Daniel is bitter that i tried to use a pseudonym on the code but he > > strangely has nothing to say to say this time round. > > I think that any attempt to convert this conversation to personal matters > involving feelings and emotions is unacceptable on any kind of technical > mailing > list both open source or closed source. I'm sure you can understand that > people > have different working hours from different time zones and have many > pressing > issues originating from dozens of mailing lists to focus on to keep our > open > source mission rolling. We are very serious about open source (every > project > should for that matter) and this *should* not become a playground arguing > about > authorships. > i don't find anything exactly relevant to this issue in whatever you have written. > > Erik > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:49:57AM +0300, David Kiarie wrote: > On Fri, Feb 22, 2019 at 11:42 AM David Kiarie <davidkiarie4@gmail.com> > wrote: > > > > > > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> > > wrote: > > > >> On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > >> > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > >> > > it looks sensible that the copyright notice on the affected files in > >> > > updated as in this patch so as to also cover another party who hugely > >> > > participated in writing the code. > >> > > >> > I must point out that you specifically asked us to remove your name > >> > from the files: > >> > > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > >> > > >> > Which was fulfilled after the discussion in the thread above by: > >> > > >> > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > > as you can see, this request was fulfilled within minutes, mostly because > Daniel is bitter that i tried to use a pseudonym on the code but he > strangely has nothing to say to say this time round. This is an inappropriate personal accusation. Please refrain from such language. The use of a pseudonym was rejected because it is the project's longterm policy to not accept pseudonym, only real names. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:42:04 +0300, David Kiarie wrote: > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> wrote: > > > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > > > it looks sensible that the copyright notice on the affected files in > > > > updated as in this patch so as to also cover another party who hugely > > > > participated in writing the code. > > > > > > I must point out that you specifically asked us to remove your name > > > from the files: > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > > > > > > Which was fulfilled after the discussion in the thread above by: > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > > > And now lives in the repo as: > > > > > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 > > > Author: David Kiarie <davidkiarie4@gmail.com> > > > Date: Tue May 8 15:40:00 2018 +0300 > > > > > > xenconfig: remove my name and email from files > > > > > > > > > Did you change your mind? > > > > yes, i will actually share the copyright, if possible. Given our previous experience I'm worried that you might change your mind again. I'd like you to pledge that it's your final decision and you will not attempt to delete it again after some time. > > Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to > > add your name into a Copyright line now. Only SUSE was mentioned as the > > copyright holder when you created the files. This makes me think you > > might have contributed this as part of your contract with SUSE in which > > case you are most likely not the copyright holder (even though you > > didn't use a @suse.com email, but that's not rare some people just keep > > using their personal email). > > > > i did this as part of GSoC. there was no contract. I'm not entirely sure, but we might want to ask the SuSE folks whether they agree. > i think an email is personal enough that it shouldn't appear on copyright > notice just like i can't have my phone number on the copyright declaration. As we've pointed out when you wanted to delete your name in the first place, most of the people looking at the code will be able to figure out the commit that added your name here and that commit does show your e-mail address. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
> > > > > > > > > > > > > Did you change your mind? > > > > > > > yes, i will actually share the copyright, if possible. > > Given our previous experience I'm worried that you might change your > mind again. > > I'd like you to pledge that it's your final decision and you will > not attempt to delete it again after some time. > what previous experience? this is the second time we're discussing this issue. this issue was never sorted in the very first place. i could also claim that it doesn't look like you're up to solving the issue. one year is not exactly "after some time". > > > Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to > > > add your name into a Copyright line now. Only SUSE was mentioned as the > > > copyright holder when you created the files. This makes me think you > > > might have contributed this as part of your contract with SUSE in which > > > case you are most likely not the copyright holder (even though you > > > didn't use a @suse.com email, but that's not rare some people just > keep > > > using their personal email). > > > > > > > i did this as part of GSoC. there was no contract. > > I'm not entirely sure, but we might want to ask the SuSE folks whether > they agree. > i guess you can do that. my mentor was jim, he's around libvirt a lot. > > > i think an email is personal enough that it shouldn't appear on copyright > > notice just like i can't have my phone number on the copyright > declaration. > > As we've pointed out when you wanted to delete your name in the first > place, most of the people looking at the code will be able to figure out > the commit that added your name here and that commit does show your > e-mail address. > i'd say this is okay but i don't see the problem with me sharing the copyright. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 2/22/19 2:06 AM, David Kiarie wrote:
> > i did this as part of GSoC. there was no contract.
>
> I'm not entirely sure, but we might want to ask the SuSE folks whether
> they agree.
>
>
> i guess you can do that. my mentor was jim, he's around libvirt a lot.
David is correct. There was no contract between him and SUSE. His work in the
xl<->xml converter was done under a broader GSoC project.
It sounds like the main grievance is the SUSE copyright in
src/xenconfig/xen_xl.{ch} and tests/xlconfigtest.c. I suppose that came by way
of copy-and-paste from other files. I'd be more than happy to send a patch
removing the SUSE copyright from those files if that will put closure to this issue.
Regards,
Jim
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Feb 25, 2019 at 8:04 PM Jim Fehlig <jfehlig@suse.com> wrote:
> On 2/22/19 2:06 AM, David Kiarie wrote:
> > > i did this as part of GSoC. there was no contract.
> >
> > I'm not entirely sure, but we might want to ask the SuSE folks
> whether
> > they agree.
> >
> >
> > i guess you can do that. my mentor was jim, he's around libvirt a lot.
>
> David is correct. There was no contract between him and SUSE. His work in
> the
> xl<->xml converter was done under a broader GSoC project.
>
> It sounds like the main grievance is the SUSE copyright in
> src/xenconfig/xen_xl.{ch} and tests/xlconfigtest.c. I suppose that came by
> way
> of copy-and-paste from other files. I'd be more than happy to send a patch
> removing the SUSE copyright from those files if that will put closure to
> this issue.
>
issue long closed (or at least as far as i am concerned :-)) and anyways
removing SUSE copyright from the files wasn't the right solution to the
issue.
>
> Regards,
> Jim
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 11:42:04AM +0300, David Kiarie wrote: > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> wrote: > > > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > > > it looks sensible that the copyright notice on the affected files in > > > > updated as in this patch so as to also cover another party who hugely > > > > participated in writing the code. > > > > > > I must point out that you specifically asked us to remove your name > > > from the files: > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > > > > > > Which was fulfilled after the discussion in the thread above by: > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > > > And now lives in the repo as: > > > > > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 > > > Author: David Kiarie <davidkiarie4@gmail.com> > > > Date: Tue May 8 15:40:00 2018 +0300 > > > > > > xenconfig: remove my name and email from files > > > > > > > > > Did you change your mind? > > > > yes, i will actually share the copyright, if possible. Note that you already own the copyright on any code you contributed, regardless of whether any Copyright line exists in the files. The only way you loose coyright ownership is by explicitly assigning it to another person / organization. This is why the majority of patches never bother to add any copyright lines. > i think an email is personal enough that it shouldn't appear on copyright > notice just like i can't have my phone number on the copyright declaration. Your email is public regardless because every mail on this mailing list is public, and every git commit to libvirt is public, and every release of libvirt contains a AUTHORS file which includes every name + email address. IOW your email address in the source header makes no difference, it is already widely publicised. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Feb 22, 2019 at 2:03 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > On Fri, Feb 22, 2019 at 11:42:04AM +0300, David Kiarie wrote: > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> > wrote: > > > > > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > > > > it looks sensible that the copyright notice on the affected files > in > > > > > updated as in this patch so as to also cover another party who > hugely > > > > > participated in writing the code. > > > > > > > > I must point out that you specifically asked us to remove your name > > > > from the files: > > > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html > > > > > > > > Which was fulfilled after the discussion in the thread above by: > > > > > > > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html > > > > > > > > And now lives in the repo as: > > > > > > > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19 > > > > Author: David Kiarie <davidkiarie4@gmail.com> > > > > Date: Tue May 8 15:40:00 2018 +0300 > > > > > > > > xenconfig: remove my name and email from files > > > > > > > > > > > > Did you change your mind? > > > > > > > yes, i will actually share the copyright, if possible. > > Note that you already own the copyright on any code you contributed, > regardless of whether any Copyright line exists in the files. The only > way you loose coyright ownership is by explicitly assigning it to > another person / organization. This is why the majority of patches > never bother to add any copyright lines. > the copyright notice you have on these files, especially the file xen_xl.c does not respect other parties who participated in the writing the code. > > > i think an email is personal enough that it shouldn't appear on copyright > > notice just like i can't have my phone number on the copyright > declaration. > > Your email is public regardless because every mail on this mailing list > is public, and every git commit to libvirt is public, and every release > of libvirt contains a AUTHORS file which includes every name + email > address. IOW your email address in the source header makes no difference, > it is already widely publicised. > i do not want my email on the source header as someone grabbed it elsewhere and it didn't end well. i'd rather someone digs into the commits if they want my email, next time not just finds an issue in a file, quickly grabs the email and directs the complain to me. > > Regards, > Daniel > > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.