[v2] Make use of autofree within storage code

[libvirt] [PATCH v2 20/32] test: Remove unused @xml from testDomainSnapshotCreateXML

Posted by John Ferlan 7 years ago

Commit 390c06b67 added @xml, but it was never used.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---
 src/test/test_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index f51efa51b7..1dde92e961 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -6339,7 +6339,6 @@ testDomainSnapshotCreateXML(virDomainPtr domain,
     virDomainSnapshotObjPtr snap = NULL;
     virDomainSnapshotPtr snapshot = NULL;
     virObjectEventPtr event = NULL;
-    char *xml = NULL;
     bool update_current = true;
     bool redefine = flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE;
     unsigned int parse_flags = VIR_DOMAIN_SNAPSHOT_PARSE_DISKS;
@@ -6424,7 +6423,6 @@ testDomainSnapshotCreateXML(virDomainPtr domain,
 
     snapshot = virGetDomainSnapshot(domain, snap->def->name);
  cleanup:
-    VIR_FREE(xml);
     if (vm) {
         if (snapshot) {
             virDomainSnapshotObjPtr other;
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 20/32] test: Remove unused @xml from testDomainSnapshotCreateXML

Posted by Ján Tomko 6 years, 12 months ago

On Fri, Feb 08, 2019 at 01:37:14PM -0500, John Ferlan wrote:
>Commit 390c06b67 added @xml, but it was never used.
>
>Signed-off-by: John Ferlan <jferlan@redhat.com>
>Reviewed-by: Erik Skultety <eskultet@redhat.com>
>---
> src/test/test_driver.c | 2 --
> 1 file changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list