[libvirt] [PATCH] qemu: remove check for 'qemu' binary

Daniel P. Berrangé posted 1 patch 3 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190131131944.14466-1-berrange@redhat.com
src/qemu/qemu_capabilities.c | 6 ------
1 file changed, 6 deletions(-)

[libvirt] [PATCH] qemu: remove check for 'qemu' binary

Posted by Daniel P. Berrangé 3 weeks ago
The 'qemu' binary used to provide the i386 emulator until it was renamed
to qemu-system-i386 in QEMU 1.0. Since we don't support such old
versions we don't need to check for 'qemu' when probing capabilities.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/qemu/qemu_capabilities.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index f504db7d05..5cf4b617c6 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -744,12 +744,6 @@ virQEMUCapsFindBinaryForArch(virArch hostarch,
             goto out;
     }
 
-    /* Third attempt, i686 only: try 'qemu' */
-    if (guestarch == VIR_ARCH_I686) {
-        if ((ret = virQEMUCapsFindBinary("%s", "qemu")) != NULL)
-            goto out;
-    }
-
  out:
     return ret;
 }
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: remove check for 'qemu' binary

Posted by Erik Skultety 3 weeks ago
On Thu, Jan 31, 2019 at 01:19:44PM +0000, Daniel P. Berrangé wrote:
> The 'qemu' binary used to provide the i386 emulator until it was renamed
> to qemu-system-i386 in QEMU 1.0. Since we don't support such old
> versions we don't need to check for 'qemu' when probing capabilities.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list