tests: Fix storagepoolxml2xmltest execution for XML namespaces

[libvirt] [PATCH] tests: Fix storagepoolxml2xmltest execution for XML namespaces

John Ferlan posted 1 patch 5 years, 2 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190130153045.4857-1-jferlan@redhat.com

tests/storagepoolxml2xmltest.c | 4 ++++
1 file changed, 4 insertions(+)

Expand all Fold all

[libvirt] [PATCH] tests: Fix storagepoolxml2xmltest execution for XML namespaces

Posted by John Ferlan 5 years, 2 months ago

Only run the pool-netfs-ns-mountopts if built WITH_STORAGE_FS and only
run pool-rbd-ns-configopts if built with WITH_STORAGE_RBD since the
namespace support is only enabled if the pool is enabled.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 tests/storagepoolxml2xmltest.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c
index 90d00a8d9e..acb15f3a2c 100644
--- a/tests/storagepoolxml2xmltest.c
+++ b/tests/storagepoolxml2xmltest.c
@@ -91,7 +91,9 @@ mymain(void)
     DO_TEST("pool-netfs-protocol-ver");
     DO_TEST("pool-netfs-gluster");
     DO_TEST("pool-netfs-cifs");
+#ifdef WITH_STORAGE_FS
     DO_TEST("pool-netfs-ns-mountopts");
+#endif
     DO_TEST("pool-scsi");
     DO_TEST("pool-scsi-type-scsi-host");
     DO_TEST("pool-scsi-type-fc-host");
@@ -106,7 +108,9 @@ mymain(void)
     DO_TEST("pool-zfs");
     DO_TEST("pool-zfs-sourcedev");
     DO_TEST("pool-rbd");
+#ifdef WITH_STORAGE_RBD
     DO_TEST("pool-rbd-ns-configopts");
+#endif
     DO_TEST("pool-vstorage");
     DO_TEST("pool-iscsi-direct-auth");
     DO_TEST("pool-iscsi-direct");
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: Fix storagepoolxml2xmltest execution for XML namespaces

Posted by Ján Tomko 5 years, 2 months ago

On Wed, Jan 30, 2019 at 10:30:45AM -0500, John Ferlan wrote:
>Only run the pool-netfs-ns-mountopts if built WITH_STORAGE_FS and only
>run pool-rbd-ns-configopts if built with WITH_STORAGE_RBD since the
>namespace support is only enabled if the pool is enabled.
>
>Signed-off-by: John Ferlan <jferlan@redhat.com>
>---
> tests/storagepoolxml2xmltest.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list