scsi-disk: Device Identification fixes

[libvirt] [PATCH 0/3] scsi-disk: Device Identification fixes

Posted by Kevin Wolf 5 years, 2 months ago

The vendor specific designator in the Device Identification VPD page has
two problems:

1. It defaults to the BlockBackend name (-drive id=...), which everyone
   expected to be a host detail that the guest never sees

2. With -blockdev based setups it defaults to an empty string; if this
   default is used with more than one disk, the guest OS will interpret
   this as a single multipath disk.

We can address problem 2 immediately, and start running the deprecation
clock for problem 1.

Related bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=1669446
https://bugzilla.redhat.com/show_bug.cgi?id=1668248

Kevin Wolf (3):
  scsi-disk: Don't use empty string as device id
  scsi-disk: Add device_id property
  scsi-disk: Deprecate device_id fallback to BlockBackend name

 hw/scsi/scsi-disk.c  | 41 ++++++++++++++++++++++++++++-------------
 qemu-deprecated.texi | 22 +++++++++++++++++++++-
 2 files changed, 49 insertions(+), 14 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] scsi-disk: Device Identification fixes

Posted by Eric Blake 5 years, 2 months ago

On 1/25/19 11:46 AM, Kevin Wolf wrote:
> The vendor specific designator in the Device Identification VPD page has
> two problems:
> 
> 1. It defaults to the BlockBackend name (-drive id=...), which everyone
>    expected to be a host detail that the guest never sees
> 
> 2. With -blockdev based setups it defaults to an empty string; if this
>    default is used with more than one disk, the guest OS will interpret
>    this as a single multipath disk.
> 
> We can address problem 2 immediately, and start running the deprecation
> clock for problem 1.
> 
> Related bug reports:
> https://bugzilla.redhat.com/show_bug.cgi?id=1669446
> https://bugzilla.redhat.com/show_bug.cgi?id=1668248
> 
> Kevin Wolf (3):
>   scsi-disk: Don't use empty string as device id
>   scsi-disk: Add device_id property
>   scsi-disk: Deprecate device_id fallback to BlockBackend name

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] scsi-disk: Device Identification fixes

Posted by Kevin Wolf 5 years, 2 months ago

Am 25.01.2019 um 18:46 hat Kevin Wolf geschrieben:
> The vendor specific designator in the Device Identification VPD page has
> two problems:
> 
> 1. It defaults to the BlockBackend name (-drive id=...), which everyone
>    expected to be a host detail that the guest never sees
> 
> 2. With -blockdev based setups it defaults to an empty string; if this
>    default is used with more than one disk, the guest OS will interpret
>    this as a single multipath disk.
> 
> We can address problem 2 immediately, and start running the deprecation
> clock for problem 1.
> 
> Related bug reports:
> https://bugzilla.redhat.com/show_bug.cgi?id=1669446
> https://bugzilla.redhat.com/show_bug.cgi?id=1668248

Applied patches 1 and 2 to the block branch so that the bug is fixed.
I'll try to rewrite patch 3 along the lines Dan suggested.

Kevin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list