[libvirt] [PATCH] rpm spec: remove %{extra_release} from spec

Daniel P. Berrangé posted 1 patch 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190121125610.7980-1-berrange@redhat.com
libvirt.spec.in       | 2 +-
mingw-libvirt.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[libvirt] [PATCH] rpm spec: remove %{extra_release} from spec
Posted by Daniel P. Berrangé 5 years, 2 months ago
The %{extra_release} field was previously populated by data from the old
autobuild.sh file but is no longer used.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in       | 2 +-
 mingw-libvirt.spec.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 567721f424..2e572e2a01 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -214,7 +214,7 @@
 Summary: Library providing a simple virtualization API
 Name: libvirt
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 License: LGPLv2+
 URL: https://libvirt.org/
 
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index 7c7ab4146d..249abb8475 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -35,7 +35,7 @@
 
 Name:           mingw-libvirt
 Version:        @VERSION@
-Release:        1%{?dist}%{?extra_release}
+Release:        1%{?dist}
 Summary:        MinGW Windows libvirt virtualization library
 
 License:        LGPLv2+
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm spec: remove %{extra_release} from spec
Posted by Andrea Bolognani 5 years, 2 months ago
On Mon, 2019-01-21 at 12:56 +0000, Daniel P. Berrangé wrote:
> The %{extra_release} field was previously populated by data from the old
> autobuild.sh file but is no longer used.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in       | 2 +-
>  mingw-libvirt.spec.in | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm spec: remove %{extra_release} from spec
Posted by Daniel P. Berrangé 5 years, 2 months ago
On Mon, Jan 21, 2019 at 04:09:51PM +0100, Andrea Bolognani wrote:
> On Mon, 2019-01-21 at 12:56 +0000, Daniel P. Berrangé wrote:
> > The %{extra_release} field was previously populated by data from the old
> > autobuild.sh file but is no longer used.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  libvirt.spec.in       | 2 +-
> >  mingw-libvirt.spec.in | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>

I'm going to push the same change to various other libvirt related
repos, but won't wait for review. I'll just post what I push, since
I figure if we're ok doing it for this main repo, we can consider
it a trivial change for all the others.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm spec: remove %{extra_release} from spec
Posted by Andrea Bolognani 5 years, 2 months ago
On Tue, 2019-01-22 at 11:17 +0000, Daniel P. Berrangé wrote:
> On Mon, Jan 21, 2019 at 04:09:51PM +0100, Andrea Bolognani wrote:
> > On Mon, 2019-01-21 at 12:56 +0000, Daniel P. Berrangé wrote:
> > > The %{extra_release} field was previously populated by data from the old
> > > autobuild.sh file but is no longer used.
> > > 
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > ---
> > >  libvirt.spec.in       | 2 +-
> > >  mingw-libvirt.spec.in | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> I'm going to push the same change to various other libvirt related
> repos, but won't wait for review. I'll just post what I push, since
> I figure if we're ok doing it for this main repo, we can consider
> it a trivial change for all the others.

Sounds good to me.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list