[v2] storage: More uniquely identify NPIV LUNs

[libvirt] [PATCH v2 0/4] storage: More uniquely identify NPIV LUNs

Posted by John Ferlan 5 years, 3 months ago

v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00562.html

but no review until January, see:
https://www.redhat.com/archives/libvir-list/2019-January/msg00079.html

Changes since v1:

 * Rework code to have virStorageBackendSCSISerial use the existing
   virStorageFileGetSCSIKey

 * Then introduce and use virStorageFileGetNPIVKey in order to get a
   more unique key for NPIV LUNs. Follows same fallback policy as
   SCSI LUNs if the called *Key function either doesn't exist or fails
   to return a valid value.

John Ferlan (4):
  util: Modify virStorageFileGetSCSIKey return
  storage: Rework virStorageBackendSCSISerial
  util: Introduce virStorageFileGetNPIVKey
  storage: Fetch a unique key for vHBA/NPIV LUNs

 src/libvirt_private.syms   |   1 +
 src/storage/storage_util.c |  45 +++++++----------
 src/util/virstoragefile.c  | 101 +++++++++++++++++++++++++++++++++++--
 src/util/virstoragefile.h  |   2 +
 4 files changed, 118 insertions(+), 31 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] storage: More uniquely identify NPIV LUNs

Posted by John Ferlan 5 years, 2 months ago

ping?

Tks -

John

On 1/18/19 9:42 AM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00562.html
> 
> but no review until January, see:
> https://www.redhat.com/archives/libvir-list/2019-January/msg00079.html
> 
> Changes since v1:
> 
>  * Rework code to have virStorageBackendSCSISerial use the existing
>    virStorageFileGetSCSIKey
> 
>  * Then introduce and use virStorageFileGetNPIVKey in order to get a
>    more unique key for NPIV LUNs. Follows same fallback policy as
>    SCSI LUNs if the called *Key function either doesn't exist or fails
>    to return a valid value.
> 
> John Ferlan (4):
>   util: Modify virStorageFileGetSCSIKey return
>   storage: Rework virStorageBackendSCSISerial
>   util: Introduce virStorageFileGetNPIVKey
>   storage: Fetch a unique key for vHBA/NPIV LUNs
> 
>  src/libvirt_private.syms   |   1 +
>  src/storage/storage_util.c |  45 +++++++----------
>  src/util/virstoragefile.c  | 101 +++++++++++++++++++++++++++++++++++--
>  src/util/virstoragefile.h  |   2 +
>  4 files changed, 118 insertions(+), 31 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] storage: More uniquely identify NPIV LUNs

Posted by Michal Privoznik 5 years, 2 months ago

On 1/18/19 3:42 PM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00562.html
> 
> but no review until January, see:
> https://www.redhat.com/archives/libvir-list/2019-January/msg00079.html
> 
> Changes since v1:
> 
>   * Rework code to have virStorageBackendSCSISerial use the existing
>     virStorageFileGetSCSIKey
> 
>   * Then introduce and use virStorageFileGetNPIVKey in order to get a
>     more unique key for NPIV LUNs. Follows same fallback policy as
>     SCSI LUNs if the called *Key function either doesn't exist or fails
>     to return a valid value.
> 
> John Ferlan (4):
>    util: Modify virStorageFileGetSCSIKey return
>    storage: Rework virStorageBackendSCSISerial
>    util: Introduce virStorageFileGetNPIVKey
>    storage: Fetch a unique key for vHBA/NPIV LUNs
> 
>   src/libvirt_private.syms   |   1 +
>   src/storage/storage_util.c |  45 +++++++----------
>   src/util/virstoragefile.c  | 101 +++++++++++++++++++++++++++++++++++--
>   src/util/virstoragefile.h  |   2 +
>   4 files changed, 118 insertions(+), 31 deletions(-)
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list