[v2] Makefile.am cleanups

[libvirt] [PATCH v2 0/2] Makefile.am cleanups

Eric Blake posted 2 patches 5 years, 3 months ago

Diff against v1
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190108055842.19272-1-eblake@redhat.com

examples/Makefile.am                 |  5 ++---
examples/admin/client_close.c        |  2 --
examples/admin/client_info.c         |  3 +--
examples/admin/client_limits.c       |  2 --
examples/admin/list_clients.c        |  2 --
examples/admin/list_servers.c        |  2 --
examples/admin/logging.c             |  2 --
examples/admin/threadpool_params.c   |  2 --
examples/dommigrate/dommigrate.c     |  2 --
examples/domsuspend/suspend.c        |  2 --
examples/domtop/domtop.c             |  2 --
examples/hellolibvirt/hellolibvirt.c |  2 --
examples/object-events/event-test.c  | 12 ++++++++----
examples/openauth/openauth.c         |  2 --
examples/rename/rename.c             |  2 --
15 files changed, 11 insertions(+), 33 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/2] Makefile.am cleanups

Posted by Eric Blake 5 years, 3 months ago

Since v1:
- push patch 1, 2 that had successful reviews
- new patch 1
- rewrite old patch 3 to remove all use of gnulib from examples/,
rather than being partitioned based on what uses config.h (in part
by reverting Jan's recent patch that added config.h everywhere)

Eric Blake (2):
  examples: Drop event-test.c dependency on gnulib <verify.h>
  examples: Avoid gnulib, have standalone examples

 examples/Makefile.am                 |  5 ++---
 examples/admin/client_close.c        |  2 --
 examples/admin/client_info.c         |  3 +--
 examples/admin/client_limits.c       |  2 --
 examples/admin/list_clients.c        |  2 --
 examples/admin/list_servers.c        |  2 --
 examples/admin/logging.c             |  2 --
 examples/admin/threadpool_params.c   |  2 --
 examples/dommigrate/dommigrate.c     |  2 --
 examples/domsuspend/suspend.c        |  2 --
 examples/domtop/domtop.c             |  2 --
 examples/hellolibvirt/hellolibvirt.c |  2 --
 examples/object-events/event-test.c  | 12 ++++++++----
 examples/openauth/openauth.c         |  2 --
 examples/rename/rename.c             |  2 --
 15 files changed, 11 insertions(+), 33 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] Makefile.am cleanups

Posted by Michal Privoznik 5 years, 3 months ago

On 1/8/19 6:58 AM, Eric Blake wrote:
> Since v1:
> - push patch 1, 2 that had successful reviews
> - new patch 1
> - rewrite old patch 3 to remove all use of gnulib from examples/,
> rather than being partitioned based on what uses config.h (in part
> by reverting Jan's recent patch that added config.h everywhere)
> 
> Eric Blake (2):
>   examples: Drop event-test.c dependency on gnulib <verify.h>
>   examples: Avoid gnulib, have standalone examples
> 
>  examples/Makefile.am                 |  5 ++---
>  examples/admin/client_close.c        |  2 --
>  examples/admin/client_info.c         |  3 +--
>  examples/admin/client_limits.c       |  2 --
>  examples/admin/list_clients.c        |  2 --
>  examples/admin/list_servers.c        |  2 --
>  examples/admin/logging.c             |  2 --
>  examples/admin/threadpool_params.c   |  2 --
>  examples/dommigrate/dommigrate.c     |  2 --
>  examples/domsuspend/suspend.c        |  2 --
>  examples/domtop/domtop.c             |  2 --
>  examples/hellolibvirt/hellolibvirt.c |  2 --
>  examples/object-events/event-test.c  | 12 ++++++++----
>  examples/openauth/openauth.c         |  2 --
>  examples/rename/rename.c             |  2 --
>  15 files changed, 11 insertions(+), 33 deletions(-)
> 

ACK to both.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] Makefile.am cleanups

Posted by Ján Tomko 5 years, 3 months ago

On Mon, Jan 07, 2019 at 11:58:40PM -0600, Eric Blake wrote:
>Since v1:
>- push patch 1, 2 that had successful reviews
>- new patch 1
>- rewrite old patch 3 to remove all use of gnulib from examples/,
>rather than being partitioned based on what uses config.h (in part
>by reverting Jan's recent patch that added config.h everywhere)
>
>Eric Blake (2):
>  examples: Drop event-test.c dependency on gnulib <verify.h>
>  examples: Avoid gnulib, have standalone examples
>
> examples/Makefile.am                 |  5 ++---
> examples/admin/client_close.c        |  2 --
> examples/admin/client_info.c         |  3 +--
> examples/admin/client_limits.c       |  2 --
> examples/admin/list_clients.c        |  2 --
> examples/admin/list_servers.c        |  2 --
> examples/admin/logging.c             |  2 --
> examples/admin/threadpool_params.c   |  2 --
> examples/dommigrate/dommigrate.c     |  2 --
> examples/domsuspend/suspend.c        |  2 --
> examples/domtop/domtop.c             |  2 --
> examples/hellolibvirt/hellolibvirt.c |  2 --
> examples/object-events/event-test.c  | 12 ++++++++----
> examples/openauth/openauth.c         |  2 --
> examples/rename/rename.c             |  2 --
> 15 files changed, 11 insertions(+), 33 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list