[libvirt] [jenkins-ci PATCH] guests: Stop using squash_actions

Andrea Bolognani posted 1 patch 25 weeks ago
Failed in applying to current master (apply log)
guests/ansible.cfg                         | 1 -
guests/playbooks/update/tasks/packages.yml | 4 +---
2 files changed, 1 insertion(+), 4 deletions(-)

[libvirt] [jenkins-ci PATCH] guests: Stop using squash_actions

Posted by Andrea Bolognani 25 weeks ago
The feature is deprecated, and modern Ansible versions
complain about it. Pass the list of packages to install
to the corresponding module directly instead.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/ansible.cfg                         | 1 -
 guests/playbooks/update/tasks/packages.yml | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/guests/ansible.cfg b/guests/ansible.cfg
index 6b18c57..344646d 100644
--- a/guests/ansible.cfg
+++ b/guests/ansible.cfg
@@ -4,7 +4,6 @@ forks = 16
 inventory = ./inventory
 log_path = ./log
 nocows = 1
-squash_actions = package
 
 [ssh_connection]
 pipelining = True
diff --git a/guests/playbooks/update/tasks/packages.yml b/guests/playbooks/update/tasks/packages.yml
index a725b07..8cebb5f 100644
--- a/guests/playbooks/update/tasks/packages.yml
+++ b/guests/playbooks/update/tasks/packages.yml
@@ -66,7 +66,5 @@
 
 - name: '{{ project }}: Install/remove packages (state={{ state }})'
   package:
-    name: '{{ item }}'
+    name: '{{ flattened|sort }}'
     state: '{{ state }}'
-  with_items:
-    '{{ flattened|sort }}'
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Stop using squash_actions

Posted by Daniel P. Berrangé 25 weeks ago
On Thu, Dec 20, 2018 at 02:30:03PM +0100, Andrea Bolognani wrote:
> The feature is deprecated, and modern Ansible versions
> complain about it. Pass the list of packages to install
> to the corresponding module directly instead.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/ansible.cfg                         | 1 -
>  guests/playbooks/update/tasks/packages.yml | 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list