[libvirt] [PATCH 0/2] Fix a couple get all domain stats issues

John Ferlan posted 2 patches 5 years, 4 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181127162323.948-1-jferlan@redhat.com
src/qemu/qemu_driver.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)
[libvirt] [PATCH 0/2] Fix a couple get all domain stats issues
Posted by John Ferlan 5 years, 4 months ago
One is longer term (patch1), while the other is sourced in this
release (4.10.0) when IOThread stats were added.

John Ferlan (2):
  qemu: Save qemuDomainGetStats error
  qemu: Don't fail stats collection due to IOThread capability

 src/qemu/qemu_driver.c | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

-- 
2.17.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] Fix a couple get all domain stats issues
Posted by John Ferlan 5 years, 4 months ago
Thanks for the quick peek on patch1; however, I was hoping to have these
 patches be considered for the current release seeing as patch2 fixes a
condition introduced in the release and because the next release won't
be until mid January or so. The downside of not pushing patch2 is that
running 'virsh domstats' will fail completely on a domain that doesn't
have the IOThread capability. Without patch1, you'd only get the generic
cause is unknown reason.  If it's felt that the patches can wait for the
next release that's fine, but no harm in asking...

Tks,

John

On 11/27/18 11:23 AM, John Ferlan wrote:
> One is longer term (patch1), while the other is sourced in this
> release (4.10.0) when IOThread stats were added.
> 
> John Ferlan (2):
>   qemu: Save qemuDomainGetStats error
>   qemu: Don't fail stats collection due to IOThread capability
> 
>  src/qemu/qemu_driver.c | 28 ++++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] Fix a couple get all domain stats issues
Posted by John Ferlan 5 years, 4 months ago
ping?

Tks,

John


On 11/27/18 11:23 AM, John Ferlan wrote:
> One is longer term (patch1), while the other is sourced in this
> release (4.10.0) when IOThread stats were added.
> 
> John Ferlan (2):
>   qemu: Save qemuDomainGetStats error
>   qemu: Don't fail stats collection due to IOThread capability
> 
>  src/qemu/qemu_driver.c | 28 ++++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list