[libvirt] [PATCH v3 0/4] rpc: fixing compilation error due to deprecated functions.

Julio Faracco posted 4 patches 25 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181123195237.15802-1-jcfaracco@gmail.com
m4/virt-libssh.m4             | 12 ++++++++++++
src/rpc/virnetlibsshsession.c | 18 +++++++++++++++++-
2 files changed, 29 insertions(+), 1 deletion(-)

[libvirt] [PATCH v3 0/4] rpc: fixing compilation error due to deprecated functions.

Posted by Julio Faracco 25 weeks ago
After 0.8.0 release, libssh deprecated some functions like:
ssh_is_server_known() and ssh_write_knownhost(). They were replaced by
ssh_session_is_known_server() and ssh_session_update_known_hosts()
respectively. This serie creates the alias to keep the compatibility and
create an auxiliar enum to help it because
ssh_session_update_known_hosts() introduced new state returns.

v1-v2: Rebasing ssh_session_is_known_server() return states.
v2-v3: Only code syntax fixes.

Julio Faracco (4):
  m4: checking if ssh_session_is_known_server() exists.
  rpc: replacing ssh_is_server_known() by ssh_session_is_known_server().
  m4: checking if ssh_session_update_known_hosts() exists.
  rpc: replacing ssh_write_knownhost() by
    ssh_session_update_known_hosts().

 m4/virt-libssh.m4             | 12 ++++++++++++
 src/rpc/virnetlibsshsession.c | 18 +++++++++++++++++-
 2 files changed, 29 insertions(+), 1 deletion(-)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/4] rpc: fixing compilation error due to deprecated functions.

Posted by Andrea Bolognani 21 weeks ago
On Sat, 2018-11-24 at 03:52 +0800, Julio Faracco wrote:
> After 0.8.0 release, libssh deprecated some functions like:
> ssh_is_server_known() and ssh_write_knownhost().

This is not accurate: 0.8.5 was released less than two months ago
and does not consider any of the functions you listed as deprecated;
the deprecation is indeed in place on the master branch, which will
eventually be released as 0.9.0 or whatever.

Speaking of which, I'm not entirely convinced being *this* proactive
with respect to libssh deprecations is useful when we could at least
wait for the next stable release to be out. I'll review the patches
in more detail regardless :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/4] rpc: fixing compilation error due to deprecated functions.

Posted by Julio Faracco 21 weeks ago
I agree about versioning and stability.
The idea behind the patches is just predict the future problems related to
libssh.
Specially to discuss changes associated with deprecated functions.
And also specially because we have several Linux OSes keeping its own
package versioning.
We would not like to break anything.
I will split this serie and wait for 0.9.0 stable release.

Thanks to review, Andrea. ;-)

Em ter, 18 de dez de 2018 às 12:01, Andrea Bolognani <abologna@redhat.com>
escreveu:

> On Sat, 2018-11-24 at 03:52 +0800, Julio Faracco wrote:
> > After 0.8.0 release, libssh deprecated some functions like:
> > ssh_is_server_known() and ssh_write_knownhost().
>
> This is not accurate: 0.8.5 was released less than two months ago
> and does not consider any of the functions you listed as deprecated;
> the deprecation is indeed in place on the master branch, which will
> eventually be released as 0.9.0 or whatever.
>
> Speaking of which, I'm not entirely convinced being *this* proactive
> with respect to libssh deprecations is useful when we could at least
> wait for the next stable release to be out. I'll review the patches
> in more detail regardless :)
>
> --
> Andrea Bolognani / Red Hat / Virtualization
>
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list