[libvirt] [PATCH 0/2] rpc: fixing compilation error due to deprecated ssh_is_server_known()

Julio Faracco posted 2 patches 5 years, 5 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181116141804.12766-1-jcfaracco@gmail.com
m4/virt-libssh.m4             | 4 ++++
src/rpc/virnetlibsshsession.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
[libvirt] [PATCH 0/2] rpc: fixing compilation error due to deprecated ssh_is_server_known()
Posted by Julio Faracco 5 years, 5 months ago
After 0.8.0 release, libssh deprecated ssh_is_server_known() method to
introduce ssh_session_is_known_server(). This commit check if
ssh_session_is_known_server() is available to use. If it is not, it creates
an alias to ssh_is_server_known() during the configuration.

The commits are similar to c9da6cbe and 463fa9c7.

Julio Faracco (2):
  rpc: replacing ssh_is_server_known() by ssh_session_is_known_server().
  m4: checking if ssh_session_is_known_server() exists.

 m4/virt-libssh.m4             | 4 ++++
 src/rpc/virnetlibsshsession.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] rpc: fixing compilation error due to deprecated ssh_is_server_known()
Posted by Julio Faracco 5 years, 5 months ago
This fix has a problem partially.
The official documentation says to use ssh_session_is_known_server() now.
But the function return has changed too.
Now, it is using "enum ssh_known_hosts_e" instead of "enum ssh_server_know_e".
Some enums matches, but others don't.
Error was -1 and now it is -2 (following libssh example).
I would suggest to create an aux way to identify the return/state.
Or even use integers instead enums.
Anyone has a better idea? Obviously, with less impact and portable...

--
Julio Cesar Faracco

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list